-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search page upgrades #500
Open
mjaydenkim
wants to merge
13
commits into
main
Choose a base branch
from
matt/search-page-improvements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Search page upgrades #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to do a big more testing but I think this is good.
Don't forget to mention -- when there's no course possible due to filters, the preview card is deselected.
This reverts commit 92a427b.
Still to do: Figure out how to handle the very long mobile page, fix sorting by relevance to number of reviews if possible, run it by everyone!
Also got rid of useless comments
[diff-counting] Significant lines: 738. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades the search pages. It updates outdated React search page code to use hooks and functional components, fixes the weird spacing on the original search page, behaves more predictably when no reviews are available due to bad searches/filters, and includes overall style improvements. Please refer below for important notes.
PR Type
Mobile + Desktop Screenshots & Recordings
https://github.com/user-attachments/assets/f7085e89-734a-4f3d-81e3-10870de92a8b
Note: I got rid of the "Search Results" header wrapping onto two lines since recording this.
QA - Test Plan
Did testing on every possible feature on the search page (eg. different combos of filters, all possible sort arrangements, etc).
Breaking Changes & Notes
Added to documentation?
What GIF represents this PR?
gif