fix bug #2585 : Multitask GP Regression fails for LeaveOneOutPseudoLikelihood mll #2586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sahakpetros
changed the title
gpleiss
requested changes
Sep 13, 2024
| @@ -54,6 +54,7 @@ def forward(self, function_dist: MultivariateNormal, target: Tensor, *params) -> | |||
| :param torch.Tensor target: :math:`\mathbf y` The target values | |||
| :param dict kwargs: Additional arguments to pass to the likelihood's forward function. | |||
| """ | |||
| target = target.flatten() | |||
There was a problem hiding this comment.
This will cause errors if target is a batch of targets.
Please also add unit tests, covering both the batch and the non-batch case. Ideally, your tests should catch the error that you are trying to fix. I.e. you should have unit tests that fail before you add your code change, but pass after you add your code change.
fix bug 2585 cornellius-gp#2585
sahakpetros
force-pushed
the
patch-1
branch
from
74582fc
to
90d4f01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix bug 2585 #2585