Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports of latest version of Laravel Nova (>= 4.31) #170

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

bobdivinity
Copy link
Contributor

After upgrading laravel/nova package to 4.31, charts didn't worked as expected.
Request parameters weren't sent as string but as array. So that I changed this behaviour to handle both formats.

I also apply a small UI change to display large title charts without croping.

@coroo coroo merged commit e4e1ea4 into coroo:master Nov 21, 2023
1 check passed
@coroo
Copy link
Owner

coroo commented Nov 21, 2023

Thank you for the contribution @bobdivinity , I've release it at version 0.4.2 https://github.com/coroo/nova-chartjs/releases/tag/v0.4.2

dmason30 added a commit to TMCApplications/nova-chartjs that referenced this pull request Nov 21, 2023
dmason30 added a commit to TMCApplications/nova-chartjs that referenced this pull request Nov 21, 2023
@dmason30
Copy link
Contributor

@coroo @bobdivinity this caused an exception, see fix here #171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants