-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: expanded postings can cache wrong data when queries are issued "in the future" #6562
Conversation
Signed-off-by: alanprot <[email protected]>
5bc90ec
to
dba615b
Compare
Signed-off-by: alanprot <[email protected]>
Signed-off-by: alanprot <[email protected]>
…ter the last sample added in the head Signed-off-by: alanprot <[email protected]>
Signed-off-by: alanprot <[email protected]>
Signed-off-by: alanprot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve fuzz test to add GetSeries call and run queries at a "future" timestamp
I don't see we added this to fuzz test?
My bad.. i added to the unit test.. lemme add some on the fuzz test as well. We do not have expanded postings for get series for now but is good to add in case we add cache there in the future. |
Signed-off-by: alanprot <[email protected]>
@yeya24 Added the get series fuzzy testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
What this PR does:
See: #6556
This PR includes:
Additionally, we improved the prom to include all the matchers types: cortexproject/promqlsmith#142
Which issue(s) this PR fixes:
Fixes #6556
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]