Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicitly define the text color #184

Closed
wants to merge 0 commits into from
Closed

explicitly define the text color #184

wants to merge 0 commits into from

Conversation

fenril058
Copy link

Probably this pull request is related to "Issues with colors in edit mode #177". When I used the editable plugin with adoradark template, edit table mode show me the white background and nearly white text color which is the same as the @ini_text in the template. To avoid this situation, I add the definition of the text color explicitly.

@splitbrain
Copy link
Member

Why is the handsontable.less changed so much?

@fenril058
Copy link
Author

Oops. I completely destroyed the indent style. That is the reason that too many changes. Sorry. What I want to add is just one line; '''color: #222;''' between the line 174 and 175 of the original handsontable.less. Can I close this pull request and make a new pull request again?

@splitbrain
Copy link
Member

Sure, either force push to this branch or open a new pull request. I would prefer not to have any changes in the handsontable.less file because it comes from upstream. Better put all customizations in the less/* files and use specificity to override the defaults.

@fenril058 fenril058 closed this Oct 16, 2019
@fenril058 fenril058 deleted the textcolor branch October 16, 2019 14:06
@fenril058
Copy link
Author

It makes sense. I will open new request.

@asheenlevrai
Copy link

Hi :)

I am not sure if this issue is solved in any way currently. Please let me know of to solve the "white text on wheite background" issue if this is the case.

Thank a lot.

Best,
-a-

@asheenlevrai asheenlevrai mentioned this pull request Oct 18, 2021
@asheenlevrai
Copy link

Any update on this topic?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants