Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nibiru): Add Astrovault's Nibiru LST, xNIBI as a CW20 #5784

Merged
merged 7 commits into from
Feb 15, 2025

Conversation

Unique-Divine
Copy link
Contributor

@Unique-Divine Unique-Divine commented Jan 8, 2025

2025-01-08

  1. Syncs the Cosmos/chain-registry with the Nibiru Token Registry based on new Google Form submission.
  2. The assetlist.json is generated in the Nibiru repo (nibiru/token-registry)

Token Details

xNIBI is a liquid staking derivative created by Astrovault.

nibid q wasm contract-state smart nibi1cehpv50vl90g9qkwwny8mw7txw79zs6f7wsfe8ey7dgp238gpy4qhdqjhm '{"token_info": {}}' | jq
{
  "data": {
    "name": "xNIBI",
    "symbol": "xNIBI",
    "decimals": 6,
    "total_supply": "3635600917967"
  }
}

Unique-Divine and others added 3 commits January 7, 2025 12:25
chore(nibiru): sync with Nibiru Token Registry. Add Astrovault's Nibiru LST, xNIBI as a CW20
@Unique-Divine Unique-Divine marked this pull request as draft January 8, 2025 06:39
@Unique-Divine Unique-Divine marked this pull request as ready for review January 8, 2025 08:54
@JeremyParish69
Copy link
Collaborator

It's OK to update the names and descriptions, but same of the uploaded images are duplicates and what's already uploaded elsewhere in the registry, and we want to avoid duplication. I don't see value added by replacing the images in this case.

@Unique-Divine
Copy link
Contributor Author

Unique-Divine commented Jan 8, 2025

Applogies, meant to delete the duplicates. I'll add a commit for that

@JeremyParish69 JeremyParish69 marked this pull request as draft January 9, 2025 16:58
@Unique-Divine Unique-Divine marked this pull request as ready for review January 9, 2025 23:29
@Unique-Divine Unique-Divine marked this pull request as draft January 9, 2025 23:30
@JeremyParish69
Copy link
Collaborator

Will this PR be updated? Or has it been abandoned?

@Unique-Divine Unique-Divine marked this pull request as ready for review February 12, 2025 14:38
@Unique-Divine
Copy link
Contributor Author

Unique-Divine commented Feb 12, 2025

This is ready for review now, @JeremyParish69

@JeremyParish69
Copy link
Collaborator

The nibiru.png and -.svg images you've removed are still referenced by the NIBI asset and as a chain logo in chain.json

@JeremyParish69 JeremyParish69 marked this pull request as draft February 13, 2025 18:45
@Unique-Divine Unique-Divine marked this pull request as ready for review February 15, 2025 10:04
@JeremyParish69 JeremyParish69 merged commit 234456a into cosmos:master Feb 15, 2025
4 checks passed
Unique-Divine added a commit to NibiruChain/nibiru that referenced this pull request Feb 26, 2025
* chore(token-registry): changes for cosmos/chain-registry#5784

* ci: improve changelog-check.yml workflow to better handle a monorepo

* ci(changelog-check): improve filter

* add erc20s_official.json and document it

* impl official_erc20s.json and official_bank_coins.json

* docs: update README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants