Skip to content

Commit

Permalink
simplify PR
Browse files Browse the repository at this point in the history
  • Loading branch information
aaronc committed Sep 12, 2024
1 parent ea049da commit 23e5615
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 12 deletions.
9 changes: 0 additions & 9 deletions schema/field.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,6 @@ type Field struct {

// ReferencedType is the referenced type name when Kind is EnumKind.
ReferencedType string `json:"referenced_type,omitempty"`

// SizeLimit specifies a size limit for certain types.
// For IntegerKind, this is the number of bits of precision that can be represented.
// Currently, support for this is NOT IMPLEMENTED yet, and it is invalid to have a non-zero value.
SizeLimit uint32
}

// Validate validates the field.
Expand Down Expand Up @@ -54,10 +49,6 @@ func (c Field) Validate(typeSet TypeSet) error {
}
}

if c.SizeLimit != 0 {
return fmt.Errorf("field %q has a non-zero size limit, support for this is NOT IMPLEMENTED yet", c.Name)
}

return nil
}

Expand Down
5 changes: 2 additions & 3 deletions schema/kind.go
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,8 @@ const (
Uint64Kind

// IntegerKind represents an arbitrary precision integer number.
// Support for expressing the maximum bit precision of values using SizeLimit
// will be added in the future.
// Go Encoding: string which matches the IntegerFormat regex (note this is subject to change).
// Support for expressing the maximum bit precision of values will be added in the future.
// Go Encoding: string which matches the IntegerFormat regex (unstable, subject to change).
// JSON Encoding: base10 integer string
// Canonically encoded values should include no leading zeros.
// Equality comparison with integers should be done using numerical equality rather
Expand Down

0 comments on commit 23e5615

Please sign in to comment.