Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add autocli app wiring + remote info support #13281

Merged
merged 61 commits into from
Nov 1, 2022
Merged

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Sep 14, 2022

Description

Closes #13282

This PR adds:

  • the cosmossdk.io/core/appmodule.AppModule tag interface which implements the core API using extension interfaces instead of a handler struct
  • AppModule extension interfaces for autocli
  • autocli options provided for x/auth as an example (to be added to each module in Add AutoCLI options for each module #13293)
  • two new gRPC query endpoints which the runtime module implements:
    • /cosmos.app.v1alpha1.Query/FileDescriptorSet - for the full file descriptor set
    • /cosmos.autocli.v1.RemoteInfoService/AppOptions - autocli app options for dynamic CLI generation

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

runtime/services.go Fixed Show fixed Hide fixed
api/cosmos/autocli/v1/service.pulsar.go Fixed Show fixed Hide fixed
api/cosmos/autocli/v1/service.pulsar.go Fixed Show fixed Hide fixed
api/cosmos/autocli/v1/service.pulsar.go Fixed Show fixed Hide fixed
runtime/services.go Fixed Show fixed Hide fixed
api/cosmos/autocli/v1/service.pulsar.go Fixed Show fixed Hide fixed
@aaronc aaronc changed the title feat: add autocli remote services for dynamic clients feat: add autocli app wiring + remote info support Sep 14, 2022
runtime/cli.go Outdated Show resolved Hide resolved
runtime/services.go Fixed Show fixed Hide fixed
runtime/services.go Fixed Show fixed Hide fixed
@github-actions github-actions bot added the C:CLI label Oct 13, 2022
client/v2/cli/interface.go Outdated Show resolved Hide resolved
core/appmodule/module.go Outdated Show resolved Hide resolved
runtime/services.go Fixed Show fixed Hide fixed
runtime/services.go Fixed Show fixed Hide fixed
@tac0turtle
Copy link
Member

autocli lives in the client/v2 go module. The intention was to make it part of a v2 client implementation which is standalone from the SDK. I thought that was all discussed when autocli work started. See ADR 058

ah I see now. hopefully it expands into something more cause client/v2 but it only doing one thing defeats the purpose of calling it v2

@aaronc
Copy link
Member Author

aaronc commented Oct 26, 2022

autocli lives in the client/v2 go module. The intention was to make it part of a v2 client implementation which is standalone from the SDK. I thought that was all discussed when autocli work started. See ADR 058

ah I see now. hopefully it expands into something more cause client/v2 but it only doing one thing defeats the purpose of calling it v2

That's the plan. I'm hoping to have a new golang tx client and keyring stuff eventually. Have done a PoC of some that stuff. We can discuss more when we get there.

@github-actions github-actions bot removed the C:x/bank label Oct 26, 2022
@aaronc
Copy link
Member Author

aaronc commented Oct 26, 2022

You okay to move forward with this @tac0turtle ?

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one question but looks good

@aaronc aaronc enabled auto-merge (squash) October 30, 2022 14:21
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed tiny nits (import group and make proto-gen) to remove some diff here.

@aaronc aaronc merged commit b9e65b6 into main Nov 1, 2022
@aaronc aaronc deleted the aaronc/autocli-service branch November 1, 2022 21:35
@julienrbrt julienrbrt mentioned this pull request Nov 9, 2022
19 tasks
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AutoCLI app wiring + remote info support
4 participants