-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(x/group): extend group config and make it configurable #18448
Changes from 7 commits
39ccfd3
1feba52
46e1042
cffe185
7566ae1
2e97681
73c67c2
941e677
5e28e26
0ce9a3c
66e7a52
339750c
829e22b
861655e
f38f89c
a2fb975
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,7 +18,21 @@ message Module { | |
google.protobuf.Duration max_execution_period = 1 | ||
[(gogoproto.stdduration) = true, (gogoproto.nullable) = false, (amino.dont_omitempty) = true]; | ||
|
||
// max_metadata_len defines the max length of the metadata bytes field for various entities within the group module. | ||
// Defaults to 255 if not explicitly set. | ||
// MaxMetadataLen defines the max chars allowed in all | ||
// messages that allows creating or updating a group | ||
// with a metadata field | ||
// Defaults to 140 if not explicitly set. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This isn't true There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for pointing that out, consequences of copy paste |
||
uint64 max_metadata_len = 2; | ||
|
||
// MaxProposalTitleLen defines the max chars allowed | ||
// in string for the MsgSubmitProposal and Proposal | ||
// summary field | ||
// Defaults to 140 if not explicitly set. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ditto There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for pointing that out, consequences of copy paste |
||
uint64 max_proposal_title_len = 3; | ||
|
||
// MaxProposalSummaryLen defines the max chars allowed | ||
// in string for the MsgSubmitProposal and Proposal | ||
// summary field | ||
// Defaults to 10200 if not explicitly set. | ||
uint64 max_proposal_summary_len = 4; | ||
} |
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get this one and the gov one entry in respectively group/CHANGELOG.md and gov changelog instead of the main one?