chore!: Overwrite main with release/v0.50.x while preserving history
#23655
Conversation
github-actions
bot
added
C:CLI
C:Keys
📝 WalkthroughWalkthroughThis pull request introduces extensive modifications across configuration, documentation, and build files. Changes include the removal and restructuring of several GitHub templates and configuration files, updates to various documentation files with textual and link improvements, and significant overhauls of the Dockerfile and Makefile. The Makefile now features additional variables and enhanced control flow with conditional checks, while release, upgrade, and versioning documents have been updated or removed as appropriate. Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant Makefile
participant System
Developer->>Makefile: Run build (e.g., `make all`)
Makefile->>Makefile: Initialize build variables and configuration
Makefile->>System: Check operating system and gcc presence (if LEDGER_ENABLED is true)
alt gcc present
Makefile->>Makefile: Execute build targets (tools, build, lint, test, vulncheck)
Makefile-->>Developer: Build process successful
else gcc missing
Makefile-->>Developer: Error: gcc not found – abort build
end
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (30)
RELEASE_NOTES.md (1)
20-27: Maintenance Policy Section & Redundant ConjunctionThe Maintenance Policy section is well-articulated, explaining the transition to bug-fix-only support for v0.50.x as the upcoming v0.52 release is approached. However, in line 26 the sentence:
Start integrating with [Cosmos SDK Eden (v0.52)](https://github.com/cosmos/cosmos-sdk/blob/main/UPGRADING.md#v052x) and enjoy and the new features and performance improvements.contains a redundant "and" before "the new features". Consider simplifying this to:
Start integrating with [Cosmos SDK Eden (v0.52)](https://github.com/cosmos/cosmos-sdk/blob/main/UPGRADING.md#v052x) to enjoy the new features and performance improvements.🧰 Tools
🪛 LanguageTool
[uncategorized] ~26-~26: “and” (in addition to, following this) seems less likely than “any”.
Context: ...blob/main/UPGRADING.md#v052x) and enjoy and the new features and performance improv...(AI_HYDRA_LEO_CP_AND_ANY)
.github/ISSUE_TEMPLATE/bug-report.md (1)
8-18: Consider making the security note more prominent.The security bounty information is important but could be missed in the current comment format.
-<!-- -IMPORTANT: Prior to opening a bug report, check if it affects one of the core modules -and if its elegible for a bug bounty on `SECURITY.md`. Bugs that are not submitted -through the appropriate channels won't receive any bounty. - --> +> **IMPORTANT SECURITY NOTE** +> Before submitting a bug report, please check if it affects core modules and is eligible +> for a bug bounty in `SECURITY.md`. Bugs must be submitted through appropriate channels +> to be considered for bounties..github/ISSUE_TEMPLATE/epics.md (1)
8-13: Consider rephrasing the warning message.The current warning about proposal rejection could be more constructive and encouraging.
-v Word of caution: poorly thought-out proposals may be rejected -v without deliberation +v Note: Please ensure your proposal is well-researched and detailed +v to facilitate productive discussion.github/PULL_REQUEST_TEMPLATE.md (3)
1-7: Consider Adding a Top-Level Heading
The file begins with an HTML comment block detailing template usage. To comply with markdown linting rules (e.g., MD041) and improve file structure, consider adding a top-level heading (such as# Pull Request Template) at the very start.
17-35: Enhanced Checklist Structure
The updated Author and Reviewer checklists provide clearer instructions and include important steps such as runningmake lintandmake test. There are a few minor grammatical suggestions (for example, hyphenating “follow-up” where applicable). Overall, these improvements help standardize the review process.🧰 Tools
🪛 LanguageTool
[uncategorized] ~19-~19: Use a comma before “and” if it connects two independent clauses (unless they are closely connected and short).
Context: ...o the item if the item is not applicable and please add links to any relevant follow...(COMMA_COMPOUND_SENTENCE_3)
[grammar] ~20-~20: ‘follow up’ seems to be a compound adjective before a noun. Use a hyphen: “follow-up”.
Context: ...le and please add links to any relevant follow up issues.* I have... * [ ] included the...(CA_FOLLOW_UP)
39-39: Grammar Suggestion for Reviewer Checklist
A comma before “and” in the reviewers checklist sentence may enhance readability. For example, consider rephrasing to “… if the item is not applicable, and please add your handle…” to clearly separate the clauses.🧰 Tools
🪛 LanguageTool
[uncategorized] ~39-~39: Use a comma before “and” if it connects two independent clauses (unless they are closely connected and short).
Context: ...add a note if the item is not applicable and please add your handle next to the item...(COMMA_COMPOUND_SENTENCE_3)
CODE_OF_CONDUCT.md (2)
5-6: Review the Inclusivity Scope in the Pledge
The updated pledge no longer lists “socioeconomic status” among the characteristics. Please confirm that narrowing the scope of the anti-harassment pledge aligns with the project’s inclusivity objectives.
43-47: Update URL Schemes for Security
In the attribution section, the URLs for the Contributor Covenant have been changed fromhttpstohttp. For improved security and user trust, it is generally recommended to use securehttpslinks unless there is a specific reason for the change.README.md (1)
52-52: Grammar Suggestion for Discord Invitation
In the sentence “If you want to follow the updates or learn more about the latest design then join our Discord,” consider inserting a comma before “then” to improve flow and readability. For example: “... latest design, then join our [Discord]…”🧰 Tools
🪛 LanguageTool
[uncategorized] ~52-~52: Possible missing comma found.
Context: ... updates or learn more about the latest design then join our [Discord](https://discord...(AI_HYDRA_LEO_MISSING_COMMA)
RELEASE_PROCESS.md (2)
30-30: Upgrade Documentation Verification
The new bullet that instructs reviewers to verify that theUPGRADING.mdfile is up to date is a useful addition. Consider replacing “up to date” with the hyphenated “up‐to‐date” for better clarity.🧰 Tools
🪛 LanguageTool
[uncategorized] ~30-~30: Possible missing comma found.
Context: ...dd to the release page on GitHub. * Additionally verify that theUPGRADING.mdfile is ...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~30-~30: It appears that hyphens are missing in the adjective “up-to-date”.
Context: ... verify that theUPGRADING.mdfile is up to date and contains all the necessary informat...(UP_TO_DATE_HYPHEN)
32-35: Punctuation and Wording Refinements
For the instructions regarding workflow files:
• In the bullet fortest.yml(line 33), consider rephrasing “expect” to “except” and adjust the punctuation—for example:
•test.yml: All standalone go module tests should be removed (except./simapp,./tests, and SDK tests).
• In the bullet forbuild.yml(line 35), update “Only the SDK and SimApp needs” to “Only the SDK and SimApp need” to match proper subject–verb agreement.🧰 Tools
🪛 LanguageTool
[uncategorized] ~33-~33: Loose punctuation mark.
Context: ...cumentation deployment. *test.yml: All standalone go module tests should b...(UNLIKELY_OPENING_PUNCTUATION)
[grammar] ~33-~33: The plural determiner ‘All’ requires a plural noun.
Context: ...ation deployment. *test.yml: All standalone go module tests should be removed (expe...(ALL_NN)
[uncategorized] ~35-~35: Loose punctuation mark.
Context: ...sted directly on main. *build.yml: Only the SDK and SimApp needs to be bui...(UNLIKELY_OPENING_PUNCTUATION)
CONTRIBUTING.md (3)
12-13: Checklist Punctuation Consistency
Ensure that checklist items use consistent punctuation—adding commas where necessary (for example, before “and” when connecting independent clauses) to improve readability.
17-22: Markdown Unordered List Style
The checklist in the Author Checklist (lines 17–22) is currently using dashes. Our style guidelines prefer the asterisk (*) for unordered list items. Please update these list markers for consistency with our markdown conventions.🧰 Tools
🪛 LanguageTool
[uncategorized] ~22-~22: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...Approval](#concept-approval) * Time Bound Period * [...(EN_COMPOUND_ADJECTIVE_INTERNAL)
50-50: Minor Stylistic Suggestion
In the note regarding very small or obvious problems (line 50), consider rephrasing “very small or blatantly obvious problems” to a less emphatic wording to maintain a formal tone.🧰 Tools
🪛 LanguageTool
[style] ~50-~50: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ...](#pull-requests) below. Note: For very small or blatantly obvious problems such as t...(EN_WEAK_ADJECTIVE)
UPGRADING.md (2)
354-354: TX Config Note Correction
There is a minor grammatical error in the sentence describing the tx config usage (“the a tx config”); please change this to “a tx config”.🧰 Tools
🪛 LanguageTool
[grammar] ~354-~354: Two determiners in a row. Choose either “the” or “a”.
Context: ...``` When usingdepinject/ `app di`, the a tx config should be recreated from the ...(DT_DT)
149-150: Summarize Proto Annotation Requirements
There is a TODO note at line 149 prompting a summary of proto annotation requirements. It would be helpful to either add a brief explanation here or link to a more detailed document, so users understand what is expected of their protobuf annotations..github/PULL_REQUEST_TEMPLATE/other.md (2)
12-22: Checklist Formatting Consistency
Please ensure that the checklist items in the Author Checklist use our preferred unordered list style (asterisks instead of dashes) and that punctuation (such as commas before “and”) is applied consistently. This will improve overall readability and maintain consistency with our markdown style guidelines.🧰 Tools
🪛 LanguageTool
[uncategorized] ~12-~12: Use a comma before “and” if it connects two independent clauses (unless they are closely connected and short).
Context: ...o the item if the item is not applicable and please add links to any relevant follow...(COMMA_COMPOUND_SENTENCE_3)
[grammar] ~13-~13: ‘follow up’ seems to be a compound adjective before a noun. Use a hyphen: “follow-up”.
Context: ...le and please add links to any relevant follow up issues.* I have... - [ ] included the...(CA_FOLLOW_UP)
🪛 markdownlint-cli2 (0.17.2)
17-17: Unordered list style
Expected: asterisk; Actual: dash(MD004, ul-style)
18-18: Unordered list style
Expected: asterisk; Actual: dash(MD004, ul-style)
19-19: Unordered list style
Expected: asterisk; Actual: dash(MD004, ul-style)
20-20: Unordered list style
Expected: asterisk; Actual: dash(MD004, ul-style)
21-21: Unordered list style
Expected: asterisk; Actual: dash(MD004, ul-style)
25-33: Reviewers Checklist Clarity
The Reviewers Checklist is clear and well structured. It might be helpful to remind reviewers (perhaps via a brief note) to add their GitHub handle next to any partially reviewed checklist items, so contributors know who reviewed which parts.🧰 Tools
🪛 LanguageTool
[uncategorized] ~25-~25: Use a comma before “and” if it connects two independent clauses (unless they are closely connected and short).
Context: ...add a note if the item is not applicable and please add your handle next to the item...(COMMA_COMPOUND_SENTENCE_3)
🪛 markdownlint-cli2 (0.17.2)
30-30: Unordered list style
Expected: asterisk; Actual: dash(MD004, ul-style)
31-31: Unordered list style
Expected: asterisk; Actual: dash(MD004, ul-style)
32-32: Unordered list style
Expected: asterisk; Actual: dash(MD004, ul-style)
.github/PULL_REQUEST_TEMPLATE/docs.md (3)
1-1: Consider Using a Top-Level Heading.
It’s recommended to start the file with a top-level heading (using a single#) instead of##to comply with markdownlint MD041.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
1-1: First line in a file should be a top-level heading
null(MD041, first-line-heading, first-line-h1)
13-14: Improve Clarity in the Author Checklist Note.
Consider inserting a comma before “and” to separate the independent clauses and use “follow‐up” (with a hyphen) instead of “follow up” for clarity.🧰 Tools
🪛 LanguageTool
[uncategorized] ~13-~13: Use a comma before “and” if it connects two independent clauses (unless they are closely connected and short).
Context: ...o the item if the item is not applicable and please add links to any relevant follow...(COMMA_COMPOUND_SENTENCE_3)
[grammar] ~14-~14: ‘follow up’ seems to be a compound adjective before a noun. Use a hyphen: “follow-up”.
Context: ...le and please add links to any relevant follow up issues.* I have... - [ ] included the...(CA_FOLLOW_UP)
18-23: Standardize Unordered List Bullets.
Markdownlint expects asterisks for unordered lists rather than dashes. Consider replacing- [ ]with* [ ]for consistency.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
18-18: Unordered list style
Expected: asterisk; Actual: dash(MD004, ul-style)
19-19: Unordered list style
Expected: asterisk; Actual: dash(MD004, ul-style)
20-20: Unordered list style
Expected: asterisk; Actual: dash(MD004, ul-style)
21-21: Unordered list style
Expected: asterisk; Actual: dash(MD004, ul-style)
22-22: Unordered list style
Expected: asterisk; Actual: dash(MD004, ul-style)
23-23: Unordered list style
Expected: asterisk; Actual: dash(MD004, ul-style)
.github/ISSUE_TEMPLATE/module-readiness-checklist.md (1)
19-19: Align Link Text with URL Target.
The checklist item displays[README.md], but the URL points toSPEC-SPEC.md. For clarity, update the displayed text to[SPEC-SPEC.md]or adjust the URL so that they match.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
19-19: Unordered list style
Expected: asterisk; Actual: dash(MD004, ul-style)
19-19: Unordered list indentation
Expected: 4; Actual: 2(MD007, ul-indent)
CODING_GUIDELINES.md (3)
10-10: Correct the Typo in 'maintainbility'.
Update “maintainbility” to “maintainability” to ensure the guideline is spelled correctly.
102-102: Hyphenate 'Table-driven Tests'.
For clarity and consistency with common terminology, update “table driven tests” to “table-driven tests”.🧰 Tools
🪛 LanguageTool
[uncategorized] ~102-~102: The adjective “table-driven” is spelled with a hyphen.
Context: ... of different inputs, we prefer to use [table driven tests](https://github.com/golang/go/wik...(DRIVEN_HYPHEN)
[uncategorized] ~102-~102: The adjective “Table-driven” is spelled with a hyphen.
Context: ...b.com/golang/go/wiki/TableDrivenTests). Table driven test error messages should follow the f...(DRIVEN_HYPHEN)
146-146: Consistent Hyphenation for 'Cross-Check'.
The header “QA Team to cross check Acceptance Tests” might be clearer if “cross-check” is hyphenated.🧰 Tools
🪛 LanguageTool
[grammar] ~146-~146: The word “cross-check” is spelled with a hyphen.
Context: ...and functional testing. ### QA Team to cross check Acceptance Tests Once the AT are defin...(CROSS_COMPOUNDS)
ROADMAP.md (5)
5-5: Refine Informal Language in the Introduction.
Consider replacing “updated on a regular basis” with “updated regularly” and reviewing the punctuation for smoother reading.🧰 Tools
🪛 LanguageTool
[style] ~5-~5: ‘on a regular basis’ might be wordy. Consider a shorter alternative.
Context: ... This will be a living document updated on a regular basis. If you'd like to participate in any wo...(EN_WORDINESS_PREMIUM_ON_A_REGULAR_BASIS)
[typographical] ~5-~5: It seems that a comma is missing.
Context: ...or would like to suggest another feature please reach out to [Marko]([email protected]...(IF_PLEASE_COMMA)
119-120: Fix Typographical Error in 'Progess'.
“Progess” appears to be a typo; update it to “Progress” to maintain professionalism.🧰 Tools
🪛 LanguageTool
[style] ~120-~120: Consider using the more formal “until”.
Context: ...ted. * Progess: * On pause till ABCI 2.0 is merged ### Client UX * [ ...(TILL)
162-162: Correct Misspelling in the Objective.
Change “Depreacte global bech32 setting” to “Deprecate global bech32 setting”.
203-204: Fix Typo in 'invairants'.
“Invairants” should be corrected to “invariants” in the context of checking system properties.
270-270: Enhance Clarity in the Roadmap Conclusion.
Consider inserting a comma for clarity and hyphenating “one-year roadmap” (if that’s the intended meaning) to improve readability.🧰 Tools
🪛 LanguageTool
[uncategorized] ~270-~270: Possible missing comma found.
Context: ...hat was not. Shortly before the quarter concludes a new section will be added for the nex...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~270-~270: When a number forms part of an adjectival compound, use a hyphen.
Context: ...We are working on updating the complete one year roadmap and will be posting it here as ...(MISSING_HYPHEN)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (243)
.coderabbit.ymlis excluded by!**/*.yml.github/ISSUE_TEMPLATE/bug-report.ymlis excluded by!**/*.yml.github/ISSUE_TEMPLATE/documentation.ymlis excluded by!**/*.yml.github/ISSUE_TEMPLATE/epics.ymlis excluded by!**/*.yml.github/ISSUE_TEMPLATE/feature-request.ymlis excluded by!**/*.yml.github/codeql/config.ymlis excluded by!**/*.yml.github/dependabot.ymlis excluded by!**/*.yml.github/pr_labeler.ymlis excluded by!**/*.yml.github/workflows/auto-assign-prs.ymlis excluded by!**/*.yml.github/workflows/build-docs.ymlis excluded by!**/*.yml.github/workflows/build.ymlis excluded by!**/*.yml.github/workflows/changelog-reminder.ymlis excluded by!**/*.yml.github/workflows/codeql-analysis.ymlis excluded by!**/*.yml.github/workflows/consensuswarn.ymlis excluded by!**/*.yml.github/workflows/dependabot-update-all.ymlis excluded by!**/*.yml.github/workflows/dependencies-review.ymlis excluded by!**/*.yml.github/workflows/docker.ymlis excluded by!**/*.yml.github/workflows/fork-cherry-pick.ymlis excluded by!**/*.yml.github/workflows/gosec.ymlis excluded by!**/*.yml.github/workflows/issue_labeler.ymlis excluded by!**/*.yml.github/workflows/issues.ymlis excluded by!**/*.yml.github/workflows/lint-pr.ymlis excluded by!**/*.yml.github/workflows/lint.ymlis excluded by!**/*.yml.github/workflows/md-link-checker.ymlis excluded by!**/*.yml.github/workflows/misspell.ymlis excluded by!**/*.yml.github/workflows/pr-go-mod-tidy-mocks.ymlis excluded by!**/*.yml.github/workflows/pr_labeler.ymlis excluded by!**/*.yml.github/workflows/proto-docker.ymlis excluded by!**/*.yml.github/workflows/proto-registry.ymlis excluded by!**/*.yml.github/workflows/proto.ymlis excluded by!**/*.yml.github/workflows/release-confix.ymlis excluded by!**/*.yml.github/workflows/release-cosmovisor.ymlis excluded by!**/*.yml.github/workflows/release.ymlis excluded by!**/*.yml.github/workflows/sims-045.ymlis excluded by!**/*.yml.github/workflows/sims-046.ymlis excluded by!**/*.yml.github/workflows/sims-047.ymlis excluded by!**/*.yml.github/workflows/sims-050.ymlis excluded by!**/*.yml.github/workflows/sims-052.ymlis excluded by!**/*.yml.github/workflows/sims-nightly.ymlis excluded by!**/*.yml.github/workflows/sims.ymlis excluded by!**/*.yml.github/workflows/stale.ymlis excluded by!**/*.yml.github/workflows/staticmajor.ymlis excluded by!**/*.yml.github/workflows/test.ymlis excluded by!**/*.yml.github/workflows/v2-test.ymlis excluded by!**/*.yml.golangci.ymlis excluded by!**/*.yml.mergify.ymlis excluded by!**/*.yml.vscode/launch.jsonis excluded by!**/*.jsonapi/cosmos/accounts/defaults/base/v1/base.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/accounts/defaults/lockup/v1/lockup.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/accounts/defaults/lockup/v1/query.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/accounts/defaults/lockup/v1/tx.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/accounts/defaults/multisig/v1/multisig.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/accounts/interfaces/account_abstraction/v1/interface.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/accounts/module/v1/module.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/accounts/testing/counter/v1/counter.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/accounts/testing/rotation/v1/partial.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/accounts/v1/accounts.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/accounts/v1/genesis.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/accounts/v1/query.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/accounts/v1/query_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/accounts/v1/tx.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/accounts/v1/tx_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/app/runtime/v1alpha1/module.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/app/runtime/v2/module.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/app/v1alpha1/query.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/app/v1alpha1/query_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/auth/v1beta1/accounts.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/auth/v1beta1/auth.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/auth/v1beta1/query.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/auth/v1beta1/query_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/auth/v1beta1/tx.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/auth/v1beta1/tx_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/authz/module/v1/module.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/authz/v1beta1/authz.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/authz/v1beta1/event.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/authz/v1beta1/query.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/authz/v1beta1/query_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/authz/v1beta1/tx.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/authz/v1beta1/tx_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/autocli/v1/options.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/autocli/v1/query_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/bank/module/v1/module.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/bank/v1beta1/authz.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/bank/v1beta1/bank.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/bank/v1beta1/genesis.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/bank/v1beta1/query.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/bank/v1beta1/query_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/bank/v1beta1/tx.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/bank/v1beta1/tx_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/base/abci/v1beta1/abci.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/base/grpc/v2/service.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/base/grpc/v2/service_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/base/node/v1beta1/query.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/base/node/v1beta1/query_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/base/node/v2/query.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/base/node/v2/query_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/base/query/v1beta1/pagination.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/base/reflection/v1beta1/reflection.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/base/reflection/v1beta1/reflection_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/base/reflection/v2alpha1/reflection.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/base/reflection/v2alpha1/reflection_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/base/tendermint/v1beta1/query.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/base/tendermint/v1beta1/query_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/base/tendermint/v1beta1/types.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/base/v1beta1/coin.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/benchmark/module/v1/module.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/benchmark/v1/benchmark.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/benchmark/v1/tx.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/benchmark/v1/tx_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/circuit/v1/query.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/circuit/v1/query_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/circuit/v1/tx_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/consensus/module/v1/module.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/consensus/v1/query.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/consensus/v1/query_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/consensus/v1/tx.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/consensus/v1/tx_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/counter/module/v1/module.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/counter/v1/query.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/counter/v1/query_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/counter/v1/tx.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/counter/v1/tx_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/crisis/module/v1/module.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/crisis/v1beta1/genesis.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/crisis/v1beta1/tx.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/crisis/v1beta1/tx_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/crypto/hd/v1/hd.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/crypto/keyring/v1/record.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/crypto/secp256r1/keys.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/distribution/module/v1/module.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/distribution/v1beta1/distribution.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/distribution/v1beta1/genesis.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/distribution/v1beta1/query.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/distribution/v1beta1/query_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/distribution/v1beta1/tx.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/distribution/v1beta1/tx_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/epochs/module/v1/module.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/epochs/v1beta1/events.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/epochs/v1beta1/genesis.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/epochs/v1beta1/query.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/epochs/v1beta1/query_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/evidence/v1beta1/evidence.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/evidence/v1beta1/query.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/evidence/v1beta1/query_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/evidence/v1beta1/tx.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/evidence/v1beta1/tx_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/feegrant/v1beta1/query.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/feegrant/v1beta1/query_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/feegrant/v1beta1/tx.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/feegrant/v1beta1/tx_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/gov/module/v1/module.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/gov/v1/genesis.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/gov/v1/gov.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/gov/v1/query.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/gov/v1/query_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/gov/v1/tx.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/gov/v1/tx_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/gov/v1beta1/gov.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/gov/v1beta1/query_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/gov/v1beta1/tx.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/gov/v1beta1/tx_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/group/module/v1/module.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/group/v1/query.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/group/v1/query_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/group/v1/tx.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/group/v1/tx_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/group/v1/types.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/mint/module/v1/module.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/mint/v1beta1/mint.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/mint/v1beta1/query_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/mint/v1beta1/tx.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/mint/v1beta1/tx_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/msg/textual/v1/textual.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/nft/v1beta1/query.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/nft/v1beta1/query_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/nft/v1beta1/tx_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/orm/query/v1alpha1/query_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/params/module/v1/module.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/params/v1beta1/params.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/params/v1beta1/query.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/params/v1beta1/query_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/protocolpool/module/v1/module.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/protocolpool/v1/genesis.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/protocolpool/v1/query.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/protocolpool/v1/query_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/protocolpool/v1/tx.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/protocolpool/v1/tx_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/protocolpool/v1/types.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/query/v1/query.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/reflection/v1/reflection_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/slashing/module/v1/module.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/slashing/v1beta1/query_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/slashing/v1beta1/slashing.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/slashing/v1beta1/tx.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/slashing/v1beta1/tx_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/staking/module/v1/module.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/staking/v1beta1/authz.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/staking/v1beta1/genesis.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/staking/v1beta1/query.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/staking/v1beta1/query_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/staking/v1beta1/staking.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/staking/v1beta1/tx.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/staking/v1beta1/tx_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/store/internal/kv/v1beta1/kv.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/store/snapshots/v1/snapshot.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/store/snapshots/v2/snapshot.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/store/streaming/abci/grpc.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/store/streaming/abci/grpc_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/store/v1beta1/listening.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/store/v2/commit_info.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/streaming/v1/grpc.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/streaming/v1/grpc_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/tx/config/v1/config.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/tx/signing/v1beta1/signing.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/tx/v1beta1/service.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/tx/v1beta1/service_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/tx/v1beta1/tx.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/upgrade/v1beta1/query.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/upgrade/v1beta1/query_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/upgrade/v1beta1/tx.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/upgrade/v1beta1/tx_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/cosmos/upgrade/v1beta1/upgrade.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/validate/module/v1/module.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/vesting/module/v1/module.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/vesting/v1beta1/tx.pulsar.gois excluded by!**/*.pulsar.goapi/cosmos/vesting/v1beta1/tx_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/go.modis excluded by!**/*.modapi/go.sumis excluded by!**/*.sum,!**/*.sumapi/tendermint/abci/types.pulsar.gois excluded by!**/*.pulsar.goapi/tendermint/abci/types_grpc.pb.gois excluded by!**/*.pb.go,!**/*.pb.goapi/tendermint/crypto/keys.pulsar.gois excluded by!**/*.pulsar.goapi/tendermint/crypto/proof.pulsar.gois excluded by!**/*.pulsar.goapi/tendermint/libs/bits/types.pulsar.gois excluded by!**/*.pulsar.goapi/tendermint/p2p/types.pulsar.gois excluded by!**/*.pulsar.goapi/tendermint/types/block.pulsar.gois excluded by!**/*.pulsar.goapi/tendermint/types/evidence.pulsar.gois excluded by!**/*.pulsar.goapi/tendermint/types/params.pulsar.gois excluded by!**/*.pulsar.goapi/tendermint/types/types.pulsar.gois excluded by!**/*.pulsar.goapi/tendermint/types/validator.pulsar.gois excluded by!**/*.pulsar.goapi/tendermint/version/types.pulsar.gois excluded by!**/*.pulsar.gobaseapp/testutil/buf.gen.yamlis excluded by!**/*.yamlbaseapp/testutil/buf.lockis excluded by!**/*.lock,!**/*.lockbaseapp/testutil/messages.pb.gois excluded by!**/*.pb.go,!**/*.pb.go
📒 Files selected for processing (24)
.github/.codespellignore(0 hunks).github/CODEOWNERS(1 hunks).github/ISSUE_TEMPLATE/bug-report.md(1 hunks).github/ISSUE_TEMPLATE/epics.md(1 hunks).github/ISSUE_TEMPLATE/feature-request.md(1 hunks).github/ISSUE_TEMPLATE/module-readiness-checklist.md(1 hunks).github/ISSUE_TEMPLATE/qa.md(0 hunks).github/PULL_REQUEST_TEMPLATE.md(2 hunks).github/PULL_REQUEST_TEMPLATE/docs.md(1 hunks).github/PULL_REQUEST_TEMPLATE/other.md(1 hunks).gitignore(1 hunks)CODE_OF_CONDUCT.md(3 hunks)CODING_GUIDELINES.md(5 hunks)CONTRIBUTING.md(10 hunks)Dockerfile(3 hunks)Makefile(1 hunks)README.md(3 hunks)RELEASES.md(0 hunks)RELEASE_NOTES.md(1 hunks)RELEASE_PROCESS.md(9 hunks)ROADMAP.md(9 hunks)SECURITY.md(2 hunks)UPGRADING.md(7 hunks)UPGRADING_v2.md(0 hunks)
💤 Files with no reviewable changes (4)
- .github/.codespellignore
- UPGRADING_v2.md
- .github/ISSUE_TEMPLATE/qa.md
- RELEASES.md
✅ Files skipped from review due to trivial changes (1)
- .github/ISSUE_TEMPLATE/feature-request.md
🧰 Additional context used
🪛 LanguageTool
RELEASE_PROCESS.md
[grammar] ~26-~26: Possible typo. Did you mean “the” or “All”?
Context: ...branch prepare a new version section in the CHANGELOG.md * All links must point to their respective pu...
(DT_PRP)
[uncategorized] ~29-~29: Use a comma before ‘so’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...d changes in the version. This is needed so the bot knows which entries to add to t...
(COMMA_COMPOUND_SENTENCE_2)
[uncategorized] ~30-~30: Possible missing comma found.
Context: ...dd to the release page on GitHub. * Additionally verify that the UPGRADING.md file is ...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~30-~30: It appears that hyphens are missing in the adjective “up-to-date”.
Context: ... verify that the UPGRADING.md file is up to date and contains all the necessary informat...
(UP_TO_DATE_HYPHEN)
[uncategorized] ~33-~33: Loose punctuation mark.
Context: ...cumentation deployment. * test.yml: All standalone go module tests should b...
(UNLIKELY_OPENING_PUNCTUATION)
[grammar] ~33-~33: The plural determiner ‘All’ requires a plural noun.
Context: ...ation deployment. * test.yml: All standalone go module tests should be removed (expe...
(ALL_NN)
[uncategorized] ~35-~35: Loose punctuation mark.
Context: ...sted directly on main. * build.yml: Only the SDK and SimApp needs to be bui...
(UNLIKELY_OPENING_PUNCTUATION)
[misspelling] ~61-~61: This word is normally spelled with a hyphen.
Context: ...kporting PRs (usually done by automatic cherry pick followed by a PRs to the release branch...
(EN_COMPOUNDS_CHERRY_PICK)
[grammar] ~61-~61: The plural noun “PRs” cannot be used with the article “a”. Did you mean “a PR” or “PRs”?
Context: ...ne by automatic cherry pick followed by a PRs to the release branch). The backports m...
(A_NNS)
[uncategorized] ~73-~73: Possible missing preposition found.
Context: ...release is a submodule update, first go the submodule folder and name the tag prepe...
(AI_HYDRA_LEO_MISSING_TO)
[grammar] ~145-~145: The plural noun “Changes” expects the verb form “introduce”.
Context: ...-updates-guidelines.md). * Changes that introduces API breakages (e.g. public functions an...
(NNS_THAT_VBZ)
[uncategorized] ~213-~213: A comma may be missing after the conjunctive/linking adverb ‘Currently’.
Context: ...t Release Procedure](CONTRIBUTING.md). Currently residing Stable Release Managers: * @t...
(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
.github/PULL_REQUEST_TEMPLATE.md
[uncategorized] ~19-~19: Use a comma before “and” if it connects two independent clauses (unless they are closely connected and short).
Context: ...o the item if the item is not applicable and please add links to any relevant follow...
(COMMA_COMPOUND_SENTENCE_3)
[grammar] ~20-~20: ‘follow up’ seems to be a compound adjective before a noun. Use a hyphen: “follow-up”.
Context: ...le and please add links to any relevant follow up issues.* I have... * [ ] included the...
(CA_FOLLOW_UP)
[uncategorized] ~39-~39: Use a comma before “and” if it connects two independent clauses (unless they are closely connected and short).
Context: ...add a note if the item is not applicable and please add your handle next to the item...
(COMMA_COMPOUND_SENTENCE_3)
README.md
[uncategorized] ~52-~52: Possible missing comma found.
Context: ... updates or learn more about the latest design then join our [Discord](https://discord...
(AI_HYDRA_LEO_MISSING_COMMA)
CONTRIBUTING.md
[uncategorized] ~23-~23: The noun “Decision-Making” (= the process of deciding something) is spelled with a hyphen.
Context: ...period) * Approval Committee & Decision Making ...
(DECISION_MAKING)
[uncategorized] ~45-~45: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...f nobody has been assigned for the issue and you would like to work on it, mak...
(COMMA_COMPOUND_SENTENCE)
[style] ~50-~50: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ...](#pull-requests) below. Note: For very small or blatantly obvious problems such as t...
(EN_WEAK_ADJECTIVE)
[style] ~319-~319: ‘final conclusion’ might be wordy. Consider a shorter alternative.
Context: ...s taking longer than 4 weeks to reach a final conclusion, the Concept Approval Committee sho...
(EN_WORDINESS_PREMIUM_FINAL_CONCLUSION)
[uncategorized] ~322-~322: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...by either: * unanimously setting a new time bound period for this ADR * making changes to...
(EN_COMPOUND_ADJECTIVE_INTERNAL)
[style] ~323-~323: Consider shortening or rephrasing this to strengthen your wording.
Context: ... a new time bound period for this ADR * making changes to the Concept Approval Process (as outlin...
(MAKE_CHANGES)
[style] ~324-~324: Consider shortening or rephrasing this to strengthen your wording.
Context: ...t Approval Process (as outlined here) * making changes to the members of the Concept Approval Com...
(MAKE_CHANGES)
[uncategorized] ~326-~326: The noun “Decision-Making” (= the process of deciding something) is spelled with a hyphen.
Context: ...al Committee #### Approval Committee & Decision Making In absence of general consensus, decis...
(DECISION_MAKING)
[style] ~328-~328: Consider using only “consensus” to avoid wordiness.
Context: ...mittee & Decision Making In absence of general consensus, decision making requires 1/2 vote from...
(GENERAL_XX)
[uncategorized] ~328-~328: The noun “decision-making” (= the process of deciding something) is spelled with a hyphen.
Context: ...aking In absence of general consensus, decision making requires 1/2 vote from the two members ...
(DECISION_MAKING)
[grammar] ~339-~339: Probable usage error. Use “and” after ‘both’.
Context: ...ost all ADR discussions, both on GitHub as well as in bi-weekly Architecture Review meet...
(BOTH_AS_WELL_AS)
UPGRADING.md
[misspelling] ~141-~141: Use “an” instead of ‘a’ if the following word starts with a vowel sound, e.g. ‘an article’, ‘an hour’.
Context: ... not supported anymore. To migrate from a unsupported database to a supported dat...
(EN_A_VS_AN)
[typographical] ~141-~141: Consider adding a comma here.
Context: ...pported database to a supported database please use a database migration tool. ### Pro...
(PLEASE_COMMA)
[grammar] ~354-~354: Two determiners in a row. Choose either “the” or “a”.
Context: ...``` When using depinject / `app di`, the a tx config should be recreated from the ...
(DT_DT)
[typographical] ~423-~423: Consider adding a comma here.
Context: ...ustom signer function. To find out more please read the [signer field](../../build/bui...
(PLEASE_COMMA)
[misspelling] ~504-~504: This word is normally spelled as one.
Context: ...e binary. The rosetta tool also allows multi chain connections.
(EN_COMPOUNDS_MULTI_CHAIN)
.github/PULL_REQUEST_TEMPLATE/docs.md
[uncategorized] ~13-~13: Use a comma before “and” if it connects two independent clauses (unless they are closely connected and short).
Context: ...o the item if the item is not applicable and please add links to any relevant follow...
(COMMA_COMPOUND_SENTENCE_3)
[grammar] ~14-~14: ‘follow up’ seems to be a compound adjective before a noun. Use a hyphen: “follow-up”.
Context: ...le and please add links to any relevant follow up issues.* I have... - [ ] included the...
(CA_FOLLOW_UP)
[uncategorized] ~27-~27: Use a comma before “and” if it connects two independent clauses (unless they are closely connected and short).
Context: ...add a note if the item is not applicable and please add your handle next to the item...
(COMMA_COMPOUND_SENTENCE_3)
.github/PULL_REQUEST_TEMPLATE/other.md
[uncategorized] ~12-~12: Use a comma before “and” if it connects two independent clauses (unless they are closely connected and short).
Context: ...o the item if the item is not applicable and please add links to any relevant follow...
(COMMA_COMPOUND_SENTENCE_3)
[grammar] ~13-~13: ‘follow up’ seems to be a compound adjective before a noun. Use a hyphen: “follow-up”.
Context: ...le and please add links to any relevant follow up issues.* I have... - [ ] included the...
(CA_FOLLOW_UP)
[uncategorized] ~25-~25: Use a comma before “and” if it connects two independent clauses (unless they are closely connected and short).
Context: ...add a note if the item is not applicable and please add your handle next to the item...
(COMMA_COMPOUND_SENTENCE_3)
CODING_GUIDELINES.md
[style] ~101-~101: The phrase “a variety of” may be wordy. To make your writing clearer, consider replacing it.
Context: ...therwise. When testing a function under a variety of different inputs, we prefer to use [tab...
(A_VARIETY_OF)
[uncategorized] ~102-~102: The adjective “table-driven” is spelled with a hyphen.
Context: ... of different inputs, we prefer to use [table driven tests](https://github.com/golang/go/wik...
(DRIVEN_HYPHEN)
[uncategorized] ~102-~102: The adjective “Table-driven” is spelled with a hyphen.
Context: ...b.com/golang/go/wiki/TableDrivenTests). Table driven test error messages should follow the f...
(DRIVEN_HYPHEN)
[grammar] ~146-~146: The word “cross-check” is spelled with a hyphen.
Context: ...and functional testing. ### QA Team to cross check Acceptance Tests Once the AT are defin...
(CROSS_COMPOUNDS)
RELEASE_NOTES.md
[uncategorized] ~26-~26: “and” (in addition to, following this) seems less likely than “any”.
Context: ...blob/main/UPGRADING.md#v052x) and enjoy and the new features and performance improv...
(AI_HYDRA_LEO_CP_AND_ANY)
ROADMAP.md
[style] ~5-~5: ‘on a regular basis’ might be wordy. Consider a shorter alternative.
Context: ... This will be a living document updated on a regular basis. If you'd like to participate in any wo...
(EN_WORDINESS_PREMIUM_ON_A_REGULAR_BASIS)
[typographical] ~5-~5: It seems that a comma is missing.
Context: ...or would like to suggest another feature please reach out to [Marko]([email protected]...
(IF_PLEASE_COMMA)
[misspelling] ~48-~48: Use “an” instead of ‘a’ if the following word starts with a vowel sound, e.g. ‘an article’, ‘an hour’.
Context: ...move towards v1 and potentially line up a audit before final release. * [x] Core ...
(EN_A_VS_AN)
[misspelling] ~69-~69: Use “an” instead of ‘a’ if the following word starts with a vowel sound, e.g. ‘an article’, ‘an hour’.
Context: ...k/issues/14145) * design and merge a integration testing framework. * T...
(EN_A_VS_AN)
[style] ~120-~120: Consider using the more formal “until”.
Context: ...ted. * Progess: * On pause till ABCI 2.0 is merged ### Client UX * [ ...
(TILL)
[misspelling] ~148-~148: Use “an” instead of ‘a’ if the following word starts with a vowel sound, e.g. ‘an article’, ‘an hour’.
Context: ...R. * Objective: * Produce a RFC/ADR on how to make core composable ...
(EN_A_VS_AN)
[uncategorized] ~270-~270: Possible missing comma found.
Context: ...hat was not. Shortly before the quarter concludes a new section will be added for the nex...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~270-~270: When a number forms part of an adjectival compound, use a hyphen.
Context: ...We are working on updating the complete one year roadmap and will be posting it here as ...
(MISSING_HYPHEN)
🪛 markdownlint-cli2 (0.17.2)
.github/PULL_REQUEST_TEMPLATE.md
8-8: First line in a file should be a top-level heading
null
(MD041, first-line-heading, first-line-h1)
.github/ISSUE_TEMPLATE/module-readiness-checklist.md
19-19: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
19-19: Unordered list indentation
Expected: 4; Actual: 2
(MD007, ul-indent)
.github/PULL_REQUEST_TEMPLATE/docs.md
1-1: First line in a file should be a top-level heading
null
(MD041, first-line-heading, first-line-h1)
18-18: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
19-19: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
20-20: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
21-21: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
22-22: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
23-23: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
32-32: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
33-33: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
34-34: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
35-35: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
36-36: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
37-37: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
38-38: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
.github/PULL_REQUEST_TEMPLATE/other.md
1-1: First line in a file should be a top-level heading
null
(MD041, first-line-heading, first-line-h1)
17-17: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
18-18: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
19-19: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
20-20: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
21-21: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
30-30: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
31-31: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
32-32: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
CODING_GUIDELINES.md
112-112: Code block style
Expected: indented; Actual: fenced
(MD046, code-block-style)
⏰ Context from checks skipped due to timeout of 90000ms (24)
- GitHub Check: test-x-upgrade
- GitHub Check: test-x-evidence
- GitHub Check: test-x-nft
- GitHub Check: test-x-feegrant
- GitHub Check: test-x-circuit
- GitHub Check: test-hubl
- GitHub Check: test-simapp
- GitHub Check: test-cosmovisor
- GitHub Check: test-confix
- GitHub Check: test-clientv2
- GitHub Check: test-sim-nondeterminism
- GitHub Check: liveness-test
- GitHub Check: test-e2e
- GitHub Check: build (arm64)
- GitHub Check: test-integration
- GitHub Check: split-test-files
- GitHub Check: build (arm)
- GitHub Check: build (amd64)
- GitHub Check: Check docs build
- GitHub Check: Gosec
- GitHub Check: Analyze
- GitHub Check: golangci-lint
- GitHub Check: build
- GitHub Check: Summary
🔇 Additional comments (37)
RELEASE_NOTES.md (4)
1-4: Heading & Introduction are ClearThe header clearly identifies the release notes for Cosmos SDK v0.50.11 and provides a direct link to the release discussion, which is helpful for context and further discussion.
5-9: Highlights Section is InformativeThe Highlights section effectively communicates the release schedule and improvements. The explanation is succinct and gives readers the quick context they need.
10-15: Notable Changes are Well-ListedThe list format for notable changes is clear and includes important links (such as security advisories and feature updates). This improves traceability for changes like the fixes for [ABS-0043/ABS-0044] and the introduction of the new Linux-only backend.
16-19: Changelog Section Provides Easy NavigationThe changelog section offers direct links to both an exhaustive list of changes and a comparison view from the previous release, making it user-friendly.
.github/CODEOWNERS (2)
5-7: LGTM! Clear primary ownership designation.The consolidation of repository ownership under
@cosmos/sdk-core-devprovides clear accountability.
9-14: LGTM! Well-structured docs ownership.Clear designation of documentation configuration ownership to specific individuals.
.gitignore (1)
16-16: LGTM! Standard build directory exclusion.Common practice to ignore build artifacts.
.github/ISSUE_TEMPLATE/bug-report.md (2)
1-6: LGTM! Well-structured template metadata.Clear template name, purpose, and appropriate bug label.
20-31: LGTM! Clear template structure.Essential sections for bug reporting are well-organized.
.github/ISSUE_TEMPLATE/epics.md (2)
1-6: LGTM! Clear template metadata.Appropriate template name and epic label.
15-32: LGTM! Comprehensive epic structure.Well-organized sections that guide users to provide necessary information for epics.
Dockerfile (2)
15-15: Base Image Version Update Verification
The base image has been updated togolang:1.21-alpine(fromgolang:1.23-alpine). Please verify that downgrading the Go version is intentional and that all dependencies and build processes are compatible with version 1.21.
55-55: Updated Binary Name in COPY Directive
The copy command now retrieves the binary namedsimd(instead ofsimdv2) from the build environment. Confirm that the build process generates the binary with the correct name and that any subsequent runtime configurations reflect this change.CODE_OF_CONDUCT.md (1)
33-34: Clarify Scope and Representation
The revised scope statement now reads: “This Code of Conduct applies both within project spaces and in public spaces when an individual is representing the project or its community.” Ensure that this phrasing accurately reflects all intended contexts where the Code of Conduct should be enforced.SECURITY.md (3)
24-28: Updated Reporting Methods in Vulnerability Disclosure Table
The reporting methods table now includes both “[GitHub Private Vulnerability Reporting][gh-private-advisory]” and “[HackerOne bug bounty program][h1]”. This update provides clear options for reporters. Please ensure that these new guidelines are consistent with internal security protocols.
29-40: Clear Instructions for Vulnerability Reporting
The revised reporting instructions explain how to use GitHub’s private vulnerability reporting system—including severity ratings—and advise reporting on HackerOne first for vulnerabilities eligible for a payout. Verify that these instructions are in sync with your internal procedures and security response strategies.
69-79: Verify Reference Link Consistency
New reference links for[TIMELINE.md],[DISCLOSURE.md], and[EXAMPLES.md]have been added to help researchers understand the disclosure process. Please check that these links are correct and remain accessible in the long term.README.md (7)
5-6: Banner Image Path Update
The banner image source has been updated to a relative path (docs/static/img/banner.jpg), which should help with load times and reliability. Please confirm that the image exists at the specified location and displays correctly.
25-27: Updated Discord Link and Badge
The Discord badge and link have been updated to point tohttps://discord.com/invite/cosmosnetwork. Make sure that the new link is active and that all users are directed to the correct community channel.
32-32: Typo Fixed in Badge Alt Text
The alt text for the Lint badge has been corrected from “Lint Satus” to “Lint Status.” This improvement aids clarity and maintains consistency across badges.
37-39: Notice on Breaking Changes and Go Version Recommendation
The added warning and note emphasize that while the Cosmos SDK has mostly stabilized, some breaking changes continue to occur, and users should use the latest maintained Go version. This is a clear heads-up for developers—please ensure that this message is well-coordinated with accompanying release notes.
43-44: Updated High-Level Intro Link
The “High-Level Intro” link now directs users tohttps://docs.cosmos.network/main/intro/overview.html. Confirm that this link leads to the correct, up-to-date documentation page.
59-62: Addition of Cosmos Hub Mainnet Section
The new “Cosmos Hub Mainnet” section, linking to thecosmos/gaiarepository, provides valuable information for users interested in mainnet details. This is a positive enhancement to the README content.
69-69: Disambiguation Notice Clarification
The disambiguation notice clearly states that this project is not related to React-Cosmos. This helps prevent any potential confusion among users and contributors.RELEASE_PROCESS.md (1)
23-24: Release Branch Creation Clarification
The instruction for creating a release branch (lines 23–24) is clear and provides good guidance on naming and protection. Please double‐check that these guidelines are fully aligned with the overall release strategy.Makefile (5)
3-15: Build Variable Initialization
The new variables (PACKAGES_NOSIMULATION, PACKAGES_SIMTEST, VERSION, CMTVERSION, COMMIT, etc.) are initialized cleanly and provide the necessary context for versioning and build directories. Their usage appears consistent with our build conventions.
19-40: Ledger Support Conditional Logic
The conditional blocks handling ledger support—differentiating between Windows (where gcc.exe) and non-Windows systems (usinguname -sandcommand -v gcc)—are well structured. Make sure the error messages clearly instruct users on installing gcc or how to disable ledger support if needed.
232-255: Test Execution Loop Robustness
Therun-teststarget loops over submodules to execute tests. Please verify that the directory discovery (viafind . -type f -name 'go.mod') and error handling work reliably across all environments. This loop is critical for ensuring every module’s tests are run and that a non-zero exit code is properly returned if a failure occurs.
392-457: Protobuf Generation and Dependency Updates
The set of protobuf-related targets (proto-gen, proto-swagger-gen, proto-format, proto-lint, proto-check-breaking, and proto-update-deps) is well organized and leverages Docker for a consistent environment. Ensure that theprotoImageName(with version0.14.0) stays current with our dependency requirements.
459-483: Localnet Target Consistency
The localnet build and debug targets are logically structured and rely on Docker compose to spin up and tear down local testnets. Confirm that any modifications in the corresponding Docker images (undercontrib/images) are correctly propagated in these targets.CONTRIBUTING.md (1)
23-26: Enhanced Governance Sections Addition
The newly added sections “Approval Committee & Decision Making”, “Committee Members”, and “Committee Criteria” add valuable clarity to our decision‐making process. Please ensure these guidelines are kept consistent with any other governance documentation.🧰 Tools
🪛 LanguageTool
[uncategorized] ~23-~23: The noun “Decision-Making” (= the process of deciding something) is spelled with a hyphen.
Context: ...period) * Approval Committee & Decision Making ...(DECISION_MAKING)
UPGRADING.md (5)
77-104: PreBlocker Integration in Module Manager
The diff movingupgradetypes.ModuleNameinto a newPreBlockerslist followed by the introduction of thePreBlockermethod (lines 77–104) is well thought out. This change cleanly separates pre–block logic from begin–block processing. Please verify that all modules requiring specific upgrade coordination have been updated accordingly.
187-194: KVStoreService Conversion for ConsensusParamsKeeper
Changing the parameter from using a raw store key (keys[consensusparamtypes.StoreKey]) to wrapping it withruntime.NewKVStoreServiceis appropriate given the new keeper API. Confirm that downstream usages expecting the raw key are updated if necessary.
202-210: Logger Supply in depinject Config Update
Addingloggerinto thedepinject.Supply()call reflects our new dependency management strategy. Please ensure that every consumer of these configurations is compatible with the change.
212-215: Removal of Logger from AppBuilder.Build Call
Removing the explicitloggerargument from theappBuilder.Build()call is consistent with the updated dependency injection procedure. It will be important to update associated documentation so that users know not to pass the logger manually.
385-393: Module Interface Updates for BeginBlock/EndBlock
The new signatures forBeginBlockandEndBlock—usingcontext.Contextand returning errors (or validator updates when needed)—are a major change. Ensure that all module implementations are updated and that compiler assertions confirm these new interfaces..github/PULL_REQUEST_TEMPLATE/other.md (1)
1-4: PR Template Description Placeholder
The new PR template begins by prompting for a description and includes a placeholder “Closes: #XXXX”. Remember to replace this placeholder with the corresponding issue number when creating a pull request.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
1-1: First line in a file should be a top-level heading
null(MD041, first-line-heading, first-line-h1)
|
This will remove a bunch of packages that are tagged from main, that works with release/v0.50.x. for other such as core, x/tx or store, that aren't compatible with v0.50 that would make sort of sense (although still a bit weird imho) |
|
The expectation is after you run this that However, I am getting stuff in my diff, when I do that with your branch. It might be because your local Also let's make sure the are no pending backports to the branch, because we will effectively abandon those backports if we don't merge them first. |
I think once we reset, we should restore post |
"restoring" = losing history of those packages. |
Methodology
To review this PR:
mega-chore/resethas a preserved history of mainSummary by CodeRabbit
New Features
Documentation
Chores