Skip to content

Commit

Permalink
feat!: bump SDK to v0.47.8-ics-lsm (backport #2919) (#2941)
Browse files Browse the repository at this point in the history
* feat!: bump SDK to v0.47.8-ics-lsm (#2919)

* bump SDK to v0.47.8-ics-lsm

* update changelog entries

* add api breaking changelog entry for 2912

* chore: bump ics; update changelogs

---------

Co-authored-by: MSalopek <[email protected]>
(cherry picked from commit 86382aa)

# Conflicts:
#	go.mod
#	go.sum

* chore: help mergify resolve conflicts

---------

Co-authored-by: Marius Poke <[email protected]>
Co-authored-by: MSalopek <[email protected]>
  • Loading branch information
3 people authored Feb 13, 2024
1 parent 41ecc84 commit 709ef5d
Show file tree
Hide file tree
Showing 10 changed files with 39 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .changelog/unreleased/api-breaking/2885-bump-ics.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
- The consumer CCV genesis state obtained from the provider chain needs to be
transformed to be compatible with older versions of consumer chains
(see [ICS docs](https://cosmos.github.io/interchain-security/consumer-development/consumer-genesis-transformation)).
([\#2885](https://github.com/cosmos/gaia/pull/2885))
([\#2919](https://github.com/cosmos/gaia/pull/2919))
2 changes: 2 additions & 0 deletions .changelog/unreleased/api-breaking/2912-vote-spam.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Reject `MsgVote` messages from accounts with less than 1 atom staked.
([\#2912](https://github.com/cosmos/gaia/pull/2912))
8 changes: 8 additions & 0 deletions .changelog/unreleased/api-breaking/2919-bump-sdk.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
- Bump [cosmos-sdk](https://github.com/cosmos/cosmos-sdk) to
[v0.47.8-ics-lsm](https://github.com/cosmos/cosmos-sdk/tree/v0.47.8-ics-lsm).
As compared to [v0.47.8](https://github.com/cosmos/cosmos-sdk/tree/v0.47.8),
this special branch of cosmos-sdk has the following API-breaking changes:
([\#2919](https://github.com/cosmos/gaia/pull/2919))
- Limit the accepted deposit coins for a proposal to the minimum proposal deposit denoms (e.g., `uatom` for Cosmos Hub). ([sdk-#19302](https://github.com/cosmos/cosmos-sdk/pull/19302))
- Add denom check to reject denoms outside of those listed in `MinDeposit`. A new `MinDepositRatio` param is added (with a default value of `0.01`) and now deposits are required to be at least `MinDepositRatio*MinDeposit` to be accepted. ([sdk-#2919](https://github.com/cosmos/cosmos-sdk/pull/19312))
- Disable the `DenomOwners` query. ([sdk-#19266](https://github.com/cosmos/cosmos-sdk/pull/19266))
12 changes: 12 additions & 0 deletions .changelog/unreleased/bug-fixes/2919-bump-sdk.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
- Bump [cosmos-sdk](https://github.com/cosmos/cosmos-sdk) to
[v0.47.8-ics-lsm](https://github.com/cosmos/cosmos-sdk/tree/v0.47.8-ics-lsm).
This special branch of cosmos-sdk backports a series of fixes for issues found
during the [Oak Security audit of SDK 0.47](https://github.com/oak-security/audit-reports/blob/master/Cosmos%20SDK/2024-01-23%20Audit%20Report%20-%20Cosmos%20SDK%20v1.0.pdf).
([\#2919](https://github.com/cosmos/gaia/pull/2919))
- Backport [sdk-#18146](https://github.com/cosmos/cosmos-sdk/pull/18146): Add denom check to reject denoms outside of those listed in `MinDeposit`. A new `MinDepositRatio` param is added (with a default value of `0.01`) and now deposits are required to be at least `MinDepositRatio*MinDeposit` to be accepted. ([sdk-#2919](https://github.com/cosmos/cosmos-sdk/pull/19312))
- Partially backport [sdk-#18047](https://github.com/cosmos/cosmos-sdk/pull/18047): Add a limit of 200 grants pruned per `EndBlock` in the feegrant module. ([sdk-#19314](https://github.com/cosmos/cosmos-sdk/pull/19314))
- Partially backport [skd-#18737](https://github.com/cosmos/cosmos-sdk/pull/18737): Add a limit of 200 grants pruned per `BeginBlock` in the authz module. ([sdk-#19315](https://github.com/cosmos/cosmos-sdk/pull/19315))
- Backport [sdk-#18173](https://github.com/cosmos/cosmos-sdk/pull/18173): Gov Hooks now returns error and are "blocking" if they fail. Expect for `AfterProposalFailedMinDeposit` and `AfterProposalVotingPeriodEnded` that will log the error and continue. ([sdk-#19305](https://github.com/cosmos/cosmos-sdk/pull/19305))
- Backport [sdk-#18189](https://github.com/cosmos/cosmos-sdk/pull/18189): Limit the accepted deposit coins for a proposal to the minimum proposal deposit denoms. ([sdk-#19302](https://github.com/cosmos/cosmos-sdk/pull/19302))
- Backport [sdk-#18214](https://github.com/cosmos/cosmos-sdk/pull/18214) and [sdk-#17352](https://github.com/cosmos/cosmos-sdk/pull/17352): Ensure that modifying the argument to `NewUIntFromBigInt` and `NewIntFromBigInt` doesn't mutate the returned value. ([sdk-#19293](https://github.com/cosmos/cosmos-sdk/pull/19293))

4 changes: 2 additions & 2 deletions .changelog/unreleased/dependencies/2885-bump-ics.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
- Bump [ICS](https://github.com/cosmos/interchain-security) to
[v3.3.0](https://github.com/cosmos/interchain-security/releases/tag/v3.3.0)
([\#2885](https://github.com/cosmos/gaia/pull/2885))
[v3.3.1-lsm](https://github.com/cosmos/interchain-security/releases/tag/v3.3.1-lsm)
([\#2919](https://github.com/cosmos/gaia/pull/2919))
4 changes: 4 additions & 0 deletions .changelog/unreleased/dependencies/2919-bump-sdk.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
- Bump [cosmos-sdk](https://github.com/cosmos/cosmos-sdk) to
[v0.47.8-ics-lsm](https://github.com/cosmos/cosmos-sdk/tree/v0.47.8-ics-lsm).
This is a special cosmos-sdk branch with support for both ICS and LSM.
([\#2919](https://github.com/cosmos/gaia/pull/2919))
4 changes: 2 additions & 2 deletions .changelog/unreleased/state-breaking/2885-bump-ics.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
- Bump [ICS](https://github.com/cosmos/interchain-security) to
[v3.3.0](https://github.com/cosmos/interchain-security/releases/tag/v3.3.0)
([\#2885](https://github.com/cosmos/gaia/pull/2885))
[v3.3.1-lsm](https://github.com/cosmos/interchain-security/releases/tag/v3.3.1-lsm)
([\#2919](https://github.com/cosmos/gaia/pull/2919))
5 changes: 5 additions & 0 deletions .changelog/unreleased/state-breaking/2919-bump-sdk.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
- Bump [cosmos-sdk](https://github.com/cosmos/cosmos-sdk) to
[v0.47.8-ics-lsm](https://github.com/cosmos/cosmos-sdk/tree/v0.47.8-ics-lsm).
This is a special cosmos-sdk branch with support for both ICS and LSM.
([\#2919](https://github.com/cosmos/gaia/pull/2919))
- Skip running `addDenomReverseIndex` in `bank/v3` migration as it is prohibitively expensive to run on the Cosmos Hub. ([sdk-#19266](https://github.com/cosmos/cosmos-sdk/pull/19266))
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ replace (
github.com/99designs/keyring => github.com/cosmos/keyring v1.2.0

// Use special SDK v0.47.x release with support for both ICS and LSM
github.com/cosmos/cosmos-sdk => github.com/cosmos/cosmos-sdk v0.47.8-ics-lsm-rc0
github.com/cosmos/cosmos-sdk => github.com/cosmos/cosmos-sdk v0.47.8-ics-lsm

// TODO: remove it: https://github.com/cosmos/cosmos-sdk/issues/13134
github.com/dgrijalva/jwt-go => github.com/golang-jwt/jwt/v4 v4.4.2
Expand Down
4 changes: 2 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -600,8 +600,8 @@ github.com/cosmos/btcutil v1.0.5 h1:t+ZFcX77LpKtDBhjucvnOH8C2l2ioGsBNEQ3jef8xFk=
github.com/cosmos/btcutil v1.0.5/go.mod h1:IyB7iuqZMJlthe2tkIFL33xPyzbFYP0XVdS8P5lUPis=
github.com/cosmos/cosmos-proto v1.0.0-beta.2 h1:X3OKvWgK9Gsejo0F1qs5l8Qn6xJV/AzgIWR2wZ8Nua8=
github.com/cosmos/cosmos-proto v1.0.0-beta.2/go.mod h1:+XRCLJ14pr5HFEHIUcn51IKXD1Fy3rkEQqt4WqmN4V0=
github.com/cosmos/cosmos-sdk v0.47.8-ics-lsm-rc0 h1:YnngOPoBMFXXixUOq8SAmnWR4yfnliOdQZit3yA2qdc=
github.com/cosmos/cosmos-sdk v0.47.8-ics-lsm-rc0/go.mod h1:Rx0pFb7vaFKsgRjFpBzUB+1HT4sQm11MHADdkpJlvuc=
github.com/cosmos/cosmos-sdk v0.47.8-ics-lsm h1:CcNTIPRvn5Q+Xb5Y4RC4hGQZl4r6TuWlWcG7YaIEwj0=
github.com/cosmos/cosmos-sdk v0.47.8-ics-lsm/go.mod h1:Rx0pFb7vaFKsgRjFpBzUB+1HT4sQm11MHADdkpJlvuc=
github.com/cosmos/go-bip39 v0.0.0-20180819234021-555e2067c45d/go.mod h1:tSxLoYXyBmiFeKpvmq4dzayMdCjCnu8uqmCysIGBT2Y=
github.com/cosmos/go-bip39 v1.0.0 h1:pcomnQdrdH22njcAatO0yWojsUnCO3y2tNoV1cb6hHY=
github.com/cosmos/go-bip39 v1.0.0/go.mod h1:RNJv0H/pOIVgxw6KS7QeX2a0Uo0aKUlfhZ4xuwvCdJw=
Expand Down

0 comments on commit 709ef5d

Please sign in to comment.