fix: export only active consensus validators to genesis #3490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fastfadingviolets
force-pushed
the
fix/export-import
branch
from
2fb0e6d to
e4ce99d
Compare
|
Here's a passing set of tests: https://github.com/cosmos/gaia/actions/runs/12994840247 |
fastfadingviolets
requested review from
dasanchez,
LexaMichaelides and
a team
as code owners
When exporting a chain to a genesis file, there's a field in the genesis called "validators" that contains the validators that'll be used to bootstrap consensus. This is separate to the list of all validators, bonded and otherwise, kept in the staking module's app_state. If this field contains anything other than those validators that're actively participating in consensus, the chain import will fail. Thus, we shouldn't add all the validators from the staking module to this field, but only those we want used for consensus.
fastfadingviolets
force-pushed
the
fix/export-import
branch
from
e4ce99d to
918e32a
Compare
vladjdk
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When exporting a chain to a genesis file, there's a field in the genesis called "validators" that contains the validators that'll be used to bootstrap consensus. This is separate to the list of all validators, bonded and otherwise, kept in the staking module's app_state. If this field contains anything other than those validators that're actively participating in consensus, the chain import will fail. Thus, we shouldn't add all the validators from the staking module to this field, but only those we want used for consensus.
(Cont'd from #3445, opened this one so it could be in
cosmos/gaia& i could run workflows)Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API, client, or state breaking change (i.e., requires minor or major version bump).changelog(for details, see contributing guidelines)Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change