Apply validation/execution separation on Module and Router

[Farhad-Shabani]

Closes: #465

---

PR author checklist:

• Added changelog entry, using unclog.
• Added tests.
• Linked to GitHub issue.
• Updated code comments and documentation (e.g., docs/).
• Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

• Reviewed Files changed in the GitHub PR explorer.
• Manually tested (in case integration/unit/mock tests are absent).

[codecov]

Codecov Report

Base: 71.30% // Head: 71.59% // Increases project coverage by +0.28% 🎉

Coverage data is based on head (fef3fab) compared to base (c4cb0d4).
Patch coverage: 89.33% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #469      +/-   ##
==========================================
+ Coverage   71.30%   71.59%   +0.28%     
==========================================
  Files         126      127       +1     
  Lines       15935    15883      -52     
==========================================
+ Hits        11363    11371       +8     
+ Misses       4572     4512      -60     

Impacted Files	Coverage Δ
crates/ibc/src/events.rs	24.02% <ø> (ø)
crates/ibc/src/core/ics26_routing/router.rs	42.85% <42.85%> (ø)
crates/ibc/src/core/ics26_routing/module.rs	81.35% <86.53%> (ø)
crates/ibc/src/mock/context.rs	78.39% <96.15%> (+4.63%)	⬆️
crates/ibc/src/core/context.rs	82.35% <100.00%> (-2.00%)	⬇️
crates/ibc/src/core/context/acknowledgement.rs	97.32% <100.00%> (ø)
crates/ibc/src/core/context/chan_close_confirm.rs	96.29% <100.00%> (ø)
crates/ibc/src/core/context/chan_close_init.rs	96.49% <100.00%> (ø)
crates/ibc/src/core/context/chan_open_ack.rs	96.80% <100.00%> (ø)
crates/ibc/src/core/context/chan_open_confirm.rs	96.87% <100.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[plafer]

IIRC, we hadn't solved all the problems with this implementation right?

Also, I'm no longer clear on why this change is needed.

[Farhad-Shabani]

Right, forget this PR and do not put your time into it.
Closing it in favor of a new PR I'll open soon that deals with both #520 and #465