Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trying to fix error in JS code coverage upload #268

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

crodriguezvega
Copy link

No description provided.

@crodriguezvega crodriguezvega changed the title wip: trying to fix error in JS code coverage upload fix: trying to fix error in JS code coverage upload Jan 18, 2024
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7a32ca8) 49.30% compared to head (921d110) 42.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #268      +/-   ##
==========================================
- Coverage   49.30%   42.52%   -6.78%     
==========================================
  Files          23       11      -12     
  Lines       10089     2147    -7942     
  Branches       86       86              
==========================================
- Hits         4974      913    -4061     
+ Misses       4750     1191    -3559     
+ Partials      365       43     -322     
Flag Coverage Δ
go ?
rust ?
typescript 42.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. this codecov failure seems out of funk, previous diff to this didn't add/remove code/test code.

@crodriguezvega crodriguezvega merged commit 6c77125 into master Jan 18, 2024
5 of 6 checks passed
@crodriguezvega crodriguezvega deleted the carlos/fix-code-coverage-error-js branch January 18, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants