feat(relayer): relaying packet from Cosmos to Eth #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #134 +/- ##
=======================================
Coverage 96.84% 96.84%
=======================================
Files 11 11
Lines 539 539
=======================================
Hits 522 522
Misses 17 17 ☔ View full report in Codecov by Sentry. |
Closed
4 tasks
gjermundgaraba
approved these changes
Dec 4, 2024
| })) | ||
|
|
||
| var multicallTx []byte | ||
| s.Require().True(s.Run("Retrieve relay tx to Ethereum", func() { |
| s.Require().NotEmpty(resp.Tx) | ||
| s.Require().Equal(resp.Address, ics26Address.String()) | ||
|
|
||
| multicallTx = resp.Tx |
There was a problem hiding this comment.
Would we want it to be a multi call tx when it's a single tx? I haven't measured, but I would assume the cost is higher than a direct tx?
There was a problem hiding this comment.
I think consistency is always good. This is not a usecase we are optimizing for, and the gas cost of using multicall vs standard entry point should be very low, compared to all the other reasons gas will be high in that scenario
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #127, #135
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.