Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve android example: remove second launcher and fix the manifest #1052

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

radetsky
Copy link
Contributor

During the example test, I found the following deficiencies:

  1. Two application icons instead of one.
  2. SecureMessage test was not happening.
  3. The app was not loading on the API 35 + 16k page memory platform.

Fixed:

  1. fixed manifest. Now there is one icon. And the application loads adequately.
  2. Added code to start SecureMessage activity.

The example application was tested on:

  1. Android 10 phone
  2. API 33 Simulator
  3. API 34 Simulator
  4. API 35 Simulator
  5. API 35+16k Simulator

Also, I think we should accept the PR #1051
It works on 35+ Simulators and does not crash the test application.

Checklist

  • The [coding guidelines] are followed

Copy link
Contributor

@vixentael vixentael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it work for older androids or only for new?

@radetsky
Copy link
Contributor Author

I answered you in private, but yes, I tested it on Android 10 phone + API 33-35 on Simulators.
Thank you.

@vixentael vixentael added the O-Android 🤖 Operating system: Android label Aug 16, 2024
@radetsky radetsky merged commit e84a7d2 into release/0.15.0 Aug 16, 2024
5 of 6 checks passed
@radetsky radetsky deleted the rad/android_example_update branch August 16, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-Android 🤖 Operating system: Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants