Physprep docs #123
Open
Physprep docs #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for getting the ball rolling Marie. I will look into this ASAP |
|
@sangfrois For the quality assessment of the cardiac signals: setting the threshold for the std of the RR intervals to 300 seems a bit too liberal. Should this criterion be revised ? |
|
I do not see any clear physiological rationale as to where this threshold should lie. I worry we might discard valid segments. I'm opened to suggestions. |
|
I'll have to make sure everything is up to date before it is officially ready to be reviewed ! |
|
@bpinsard @julieaboyle1 |
|
@me-pic is that ready review / merge? |
|
@me-pic please rebase on main for the build to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR related to #122