Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add Abort Signal Implementation #70

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Feat: Add Abort Signal Implementation #70

wants to merge 4 commits into from

Conversation

developertom01
Copy link

@developertom01 developertom01 commented Aug 20, 2024 •
edited
Loading

  • In my application, I needed to optionally add AbortSignal to terminate retry logic.
  • This PR implements the ability to pass an AbortSignal to the retry logic. This will allow the user to cancel the retry logic if needed.
  • To support AbortConroller in typescript types, I bumped @types/node to 22.4.1 version

@developertom01 developertom01 changed the title Add Abort Signal Implementation Feat: Add Abort Signal Implementation Aug 20, 2024
@louis-bompart louis-bompart self-requested a review February 4, 2025 21:13
@samisayegh
Copy link
Collaborator

samisayegh commented Feb 4, 2025 •
edited
Loading

Could you describe the scenario that requires using the Abort API? Some pseudocode could be helpful,

Is it possible to end the retry by returning false in the retry function?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-bompart louis-bompart Awaiting requested review from louis-bompart

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@developertom01 @samisayegh