fix(members): don't notify on unexisting user

coworking-metz · May 15, 2024 · fbc2b1d · fbc2b1d
1 parent 0a11d8d
commit fbc2b1d
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/lib/models/member.js b/lib/models/member.js
@@ -220,12 +220,14 @@ export async function heartbeatMembers(memberIds, referenceDate) {
   }
 
   await Promise.all(memberIds.map(async memberId => {
-    const updatedUser = await mongo.db.collection('users').findOneAndUpdate(
+    const userBeforeUpdate = await mongo.db.collection('users').findOneAndUpdate(
       {_id: memberId},
       {$set: {'profile.heartbeat': referenceDate.toISOString()}}
     )
 
-    notifyUserBalanceDepletionOnArrival(updatedUser.value, referenceDate)
+    if (userBeforeUpdate.value) {
+      notifyUserBalanceDepletionOnArrival(userBeforeUpdate.value, referenceDate)
+    }
   }))
 }