Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(wordpress): prefer .json() over responseType: json #103

Merged
merged 1 commit into from
May 15, 2024

Conversation

mtthp
Copy link
Member

@mtthp mtthp commented May 15, 2024

Il suffisait d'enlever le .body dans response pour que ça fonctionne avec .json() puisque ce dernier fait 2 choses :

  • il demande une réponse json en header,
  • il parse le contenu comme json et le renvoie directement (plutôt que renvoyer la réponse) 🙂

@mtthp mtthp requested a review from gfra54 May 15, 2024 13:09
@gfra54
Copy link
Contributor

gfra54 commented May 15, 2024

J'ai pas d'avis mais ça a l'air très bien

@mtthp mtthp merged commit cc9e459 into master May 15, 2024
2 checks passed
@mtthp mtthp deleted the properly-parse-wordpress-user-context branch May 15, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants