Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: trading API #98
base: main
Are you sure you want to change the base?
feat: trading API #98
Changes from 26 commits
e227665
ef4b64b
1822ead
fdbc4b0
53868f1
e06f0cd
4443bf1
bc44fcf
bded4e0
7a0b81b
50de46d
e61b80f
5f5ec0f
9f5eeb2
f09ba08
48a9d5b
4958895
c374485
6117150
a3ca35a
81bdf8c
8ac2b37
c249bce
3d5a70c
15b6ec1
f4bb9fc
3061dda
af371ad
d289f14
40d87dc
8c71a9a
2116397
694375c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not adding the code to send the TX onhcain?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It very depends on a smart-contract wallet implementation.
With Safe it requires a lot of code here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Safe you can go to Transaction build and put the tx data there