New factory method to create TimeBasedEpochRandomGenerator #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
worldtiki
commented
Feb 27, 2024
worldtiki
commented
- Add factory method to create TimeBasedEpochRandomGenerator without having to specify a random number generator
- Also updated the docs so they are consisted with the other methods in the same class
…ving to specify a random number generator
| @@ -61,6 +61,16 @@ public void testExtractTimestampUUIDEpochBased() { | |||
| } | |||
| } | |||
|
|
|||
| public void testExtractTimestampUUIDEpochRandomBased() { | |||
| TimeBasedEpochRandomGenerator generator = Generators.timeBasedEpochRandomGenerator(); | |||
| final Random rnd = new Random(3); | |||
There was a problem hiding this comment.
Ah ok so this Random is just for timestamp, but otherwise we get sort of arbitrary SecureRandom.
I guess that's about what we can verify.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.