Add (and refactor) expiration helpers #1281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids using `paperDefinitions` as a config. It may not be generic enough in the future and we don't have any need for that right now.
`isExpiring` can be used instead.
This removes the need to pass a `dateLabel` argument to these helpers.
It will be used in `cozy-ui`.
They will be used in `cozy-ui`, `cozy-mespapiers-lib` and `mespapiers`.
This removes the need for `lodash/get` in `paper.js`
Paper won't be considered as expiring if the user has not set any notice period. Thus the alert won't appear and no notification will be sent.
PolariTOON
requested review from
Crash--,
Merkur39 and
paultranvan
as code owners
Merged
PolariTOON
force-pushed
the
refactor/refactor-expiration-helpers
branch
from
0cc7ed9 to
1aa29b9
Compare
|
This PR was opened to provide an alternative implementation to #1274. It is currently not clear if it's better and it makes noise, so for now let's close this PR to focus on #1274 instead because that's where most of the discussion happened. If later on it appears this way of defining each paper on a case by case basis is better, we still be able to revive it on top of the first one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an alternative to #1274, that exports the same API, with an equivalent behavior, but with a final refactor to shape it in a more declarative way, inspired by #1274 (comment) .
Thus, it can also be seen as a follow-up refactor that can land afterwards.
Therefore, the main difference is in ee5d836 and the next commits.