[WIP] feat: Remove the export from models/index #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to enhance the cozy-client tree shaking, we should avoind importing * and exporting. We had an issue with this PR #1274 because this PR adds date-fns v2 as dep, but even if the consuming app doesn't use the concerned model it was imported. BREAKING CHANGE: You can not use import { models } from cozy-client ... models.files.func() You have to change it to: import { func } from cozy-client/dist/models/files
|
still need to work on this subject to have a better understanding of the three shaking mechanism. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to enhance the cozy-client tree shaking,
we should avoind importing * and exporting.
We had an issue with this PR
#1274
because this PR adds date-fns v2 as dep, but even
if the consuming app doesn't use the concerned model it was imported.
BREAKING CHANGE: You can not use
import { models } from cozy-client
...
models.files.func()
You have to change it to:
import { func } from cozy-client/dist/models/files