fix: Dedup of date-fns #2826
Merged
fix: Dedup of date-fns #2826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the cozy-client upgrade to 34.7.1 date-fns is a needed dep for a few of its models. But we don't need them in Drive for now and we have a few issues with the tree shaking of cozy-client. (see cozy/cozy-client#1274) So the workaround is to force the resolution to date-fns 1 which is required by drive, in order to not duplicate the package. We should not have issue with that. When we'll upgrade date-fns to v2 in drive & ui, then, we'll be able to remove this line.
The commit c76ca54 seek to reduce cozy-drive bundle size but resolve search for date-fns into drive alias so I made mock to the function call waiting cozy-client to improve their tree-shaking.
cballevre
force-pushed
the
fix/OnlyOneDateFNS
branch
from
403e32d to
5aa28e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the cozy-client upgrade to 34.7.1 date-fns is a needed dep for a few of its models. But we don't need them in Drive for now and we have a few issues with the tree shaking of cozy-client.
(see cozy/cozy-client#1274)
So the workaround is to force the resolution to date-fns 1 which is required by drive, in order to not duplicate the package.
We should not have issue with that. When we'll upgrade date-fns to v2 in drive & ui, then, we'll be able to remove this line.