fix: Do not setUri on HomeView's blur if no trackedWebviewInnerUri
#423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#82 introduced `trackedWebviewInnerUri` state to keep track of WebView's URI On HomeView's blur, we would synchronize latest `trackedWebviewInnerUri` state into the `uri` state If the first user's action into the WebView is to open a cozy-app, then the HomeView's would blur with `trackedWebviewInnerUri` being null (because no navigation occurred inside of the WebView to trigger the `setTrackedWebviewInnerUri` event) This would result to calling `setUri(null)` in the blur event This behaviour was invisible to the user as `uri` would be set to cozy-home's root URL directly after that But a side effect of this is the CozyProxyWebView being unmount and remount, which would trigger the `index.html` generation process, which is unwanted By conditionally calling `setUri` based on `trackedWebviewInnerUri` nullity will prevent this behaviour
acezard
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#82 introduced
trackedWebviewInnerUristate to keep track of WebView's URIOn HomeView's blur, we would synchronize latest
trackedWebviewInnerUristate into theuristateIf the first user's action into the WebView is to open a cozy-app, then the HomeView's would blur with
trackedWebviewInnerUribeing null (because no navigation occurred inside of the WebView to trigger thesetTrackedWebviewInnerUrievent)This would result to calling
setUri(null)in the blur eventThis behaviour was invisible to the user as
uriwould be set to cozy-home's root URL directly after thatBut a side effect of this is the CozyProxyWebView being unmount and remount, which would trigger the
index.htmlgeneration process, which is unwantedBy conditionally calling
setUribased ontrackedWebviewInnerUrinullity will prevent this behaviour