Make search working on flagship #2261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
paultranvan
commented
Jan 27, 2025
•
paultranvan
commented
Ldoppea
reviewed
Jan 27, 2025
Comment on lines
33
to
39
| if (component) { | ||
| component.displayed | ||
| ? component.onDisplayed() | ||
| : component.onNotDisplayed() | ||
| } | ||
| }) | ||
| }, [appHighlightAlerts]) | ||
| } |
There was a problem hiding this comment.
Calling methods in React components but outside of a hook is considered a bad practice (those methods would be called on every rerender).
Seems like the fix here is on the added if. Would it work if keep this if but don't remove the useEffect()?
There was a problem hiding this comment.
Fair enough, fixed
At startup we check some "app highlights" status, typicallky for backup or geolocation tracking. In the tracking case, we need to query the database in order to check if there is some geolocation data. This query might fail in offline if the local database is not ready. And this failure was causing an infinite loop, because a retry was made for each failed query.
paultranvan
force-pushed
the
offline-paul
branch
from
926f0c5 to
bfecd1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.