-
Notifications
You must be signed in to change notification settings - Fork 751
Merging motions
Richard Smith edited this page Nov 19, 2019
·
2 revisions
This page describes the process the Project Editor follows when merging a motion branch.
- Open the issue and the corresponding pull request, and read any notes
git checkout master && git pull
- Check out the motion branch, ensure it's up-to-date with remote if necessary
- Rebase the branch on master, fix conflicts if necessary, and
git push --force-with-lease
-
--force-with-lease
will complain if the branch was not locally up to date or if it was modified by someone else in the meantime - Force-pushing now ensures that any edits made other than as part of rebase are visible in github
-
- [Optional if the PR is small/unlikely to conflict and has been reviewed] Rebuild the working draft, check and fix any issues
- If any issues were fixed,
git push --force-with-lease
- If any issues were fixed,
- Check pull request description
- Should contain "Fixes #MMMM" to close the motion issue
- Should contain "Fixes cplusplus/papers#MMMM" to close paper tracking issues
- Should contain "Fixes cplusplus/nbballot#MMMM" to close NB comment tracking issues
- Merge from github
- "Create a merge commit"
- Summary of commit should be "Merge YYYY-MM [CL]WG Motion NN"
- Description should list paper(s) merged
Motion branches should be merged in motion order, with no intervening commits to master.