Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to use UNITY_BUILD #63

Closed
wants to merge 1 commit into from

Conversation

ClausKlein
Copy link
Contributor

With CMAKE_UNITY_BUILD there are build error with ftxui!

  • Quickfix: don't build ftxui_sample if CMAKE_UNITY_BUILD is set.

With CMAKE_UNITY_BUILD there are build error with ftxui!

Quickfix: don't build ftxui_sample if CMAKE_UNITY_BUILD is set.
@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@9451f27). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop      #63   +/-   ##
==========================================
  Coverage           ?   24.70%           
==========================================
  Files              ?        6           
  Lines              ?      251           
  Branches           ?      142           
==========================================
  Hits               ?       62           
  Misses             ?      181           
  Partials           ?        8           
Flag Coverage Δ
Linux 16.43% <0.00%> (?)
Windows 21.42% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClausKlein ClausKlein changed the base branch from develop to main August 27, 2023 08:42
Comment on lines +56 to +58
option(myproject_ENABLE_UNITY_BUILD "Enable unity builds" ON)
option(myproject_ENABLE_CLANG_TIDY "Enable clang-tidy" OFF)
option(myproject_ENABLE_CPPCHECK "Enable cpp-check analysis" OFF)
Copy link
Contributor Author

@ClausKlein ClausKlein Aug 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO: developers shouldn't wast its time.

run-clang-tidy -p out/builddir is easy to use

Only on CI clang-tidy must at least run one times.

@ClausKlein ClausKlein marked this pull request as draft September 3, 2023 07:33
@ClausKlein ClausKlein closed this Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants