Refactor movement code. #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Format all modified files. - Use consistent casing for functions. - Use constants where warranted. - Store `world_space` in `Player` instead of `App*`. - Store `Player` in `DogTales` instead of `optional<Player>`. - Simplify bounce detection and resolution.
|
Thank you, all of these refactoring choices are great! |
Legac3e
added a commit
that referenced
this pull request
Jan 29, 2024
* Movement added to the player, wall collision detection added to the player, and the viewport is now set each frame * Refactor movement code. (#18) * Refactor movement code. - Format all modified files. - Use consistent casing for functions. - Use constants where warranted. - Store `world_space` in `Player` instead of `App*`. - Store `Player` in `DogTales` instead of `optional<Player>`. - Simplify bounce detection and resolution. * Update comments. --------- Co-authored-by: Karn Kaul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
world_spaceinPlayerinstead ofApp*.PlayerinDogTalesinstead ofoptional<Player>.This also takes care of bouncing correctly when the window is resized.
Note: this PR does not target
mainbutJake/Movement+KeyInput.