Add service locator, setup unit tests. #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move test framework into exe target. - Add CLI option to run tests instead of the game. Unit tests should ideally be in a separate executable, but that would require refactoring all the code into a library that both the game exe and unit tests exe would link to. This monolithic approach keeps things simple at the cost of game binary bloat.
- Decouple concrete type from mapped/bound type. - Use a class to own stored service instances.
|
Approved :). |
A-rms
approved these changes
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: https://gameprogrammingpatterns.com/service-locator.html
Unit tests are generally a separate executable, but to achieve that here we would have to move all the game code into a library that both the game exe and unit tests exe can link to.
Instead, here we bundle unit tests into the game exe itself, and add a command line switch to run them instead of the game. Keep the project simple at the cost of binary bloat.
To add unit tests, simply create a cpp file in
src/testsand use theADD_TESTmacro fromsrc/tests/test.hpp. Seetest_services.cppfor a working example.Running the unit tests: