-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: tagfiles generation for cross-referencing in doxygen format #670
base: develop
Are you sure you want to change the base?
feat: tagfiles generation for cross-referencing in doxygen format #670
Conversation
dd39c17
to
30d3333
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic for the Writer looks great. I think the only issue is where it would be called from.
669e5ee
to
518dfe5
Compare
The problem CI has been fixed. Could you rebase this? |
However, we will still have a problem with the USR from Krystian's commit blocking CI. I want to start by comparing the XML in the artifacts. Do you have the result for Boost.URL multipage? That's the one we can't risk breaking because it's already in production. It has to be compatible with the existing one. |
5728d41
to
4ea091f
Compare
An automated preview of the documentation is available at https://670.mrdocs.prtest2.cppalliance.org/index.html |
4ea091f
to
10d6cca
Compare
An automated preview of the documentation is available at https://670.mrdocs.prtest2.cppalliance.org/index.html |
10d6cca
to
08cbc26
Compare
An automated preview of the documentation is available at https://670.mrdocs.prtest2.cppalliance.org/index.html |
08cbc26
to
120b717
Compare
An automated preview of the documentation is available at https://670.mrdocs.prtest2.cppalliance.org/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It fails with
assertion failed: n <= indent_.size() on line 203 in src/lib/Gen/xml/XMLTags.cpp
120b717
to
e469482
Compare
An automated preview of the documentation is available at https://670.mrdocs.prtest2.cppalliance.org/index.html |
e469482
to
7b9455e
Compare
An automated preview of the documentation is available at https://670.mrdocs.prtest2.cppalliance.org/index.html |
The implementation of the tagfile write is excellent. CI failed after I rebased. That was a good thing because it helped me catch a bug. So, the reason CI is failing is trivial. The The real issue causing all of that is the API design. Your new
This bug was already there, but CI only made it evident. It worked before rebasing because Because of how If this is hard to achieve because we can't decouple the logic of This fixes the underlying problem and the original issue with |
Fixed #650