Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing template parameters in asciidoc templates #687

Conversation

fpelliccioni
Copy link
Collaborator

@fpelliccioni fpelliccioni commented Oct 3, 2024

Fixes #674

Copy link
Collaborator

@alandefreitas alandefreitas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Did you check the output?

@fpelliccioni
Copy link
Collaborator Author

Looks good. Did you check the output?

Yes, using the example given by Andrzej

@alandefreitas
Copy link
Collaborator

Oh... Great. I think we can merge this as soon as this CI issue is solved.

I think Krystian broke CI in one of his last 3 commits (some USR changed) and now there's a brand need error with the crypto package.

@alandefreitas
Copy link
Collaborator

The problem CI has been fixed. Could you rebase this?

@alandefreitas alandefreitas force-pushed the fix/tparam-missing-asciidoc-templates branch 3 times, most recently from e8d8f7b to f977759 Compare October 7, 2024 16:37
@fpelliccioni fpelliccioni force-pushed the fix/tparam-missing-asciidoc-templates branch from f977759 to be39f3c Compare October 8, 2024 18:14
@alandefreitas alandefreitas merged commit a962db0 into cppalliance:develop Oct 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tparams are missing from asciidoc templates
2 participants