fix lint

cppfw · Jan 12, 2025 · db61b9b · db61b9b
1 parent f558310
commit db61b9b
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 7 deletions.
diff --git a/src/ruis/render/factory.hpp b/src/ruis/render/factory.hpp
@@ -104,7 +104,7 @@ class factory
 
 	virtual utki::shared_ref<vertex_array> create_vertex_array(
 		std::vector<utki::shared_ref<const ruis::render::vertex_buffer>> buffers,
-		const utki::shared_ref<const ruis::render::index_buffer>& indices,
+		utki::shared_ref<const ruis::render::index_buffer> indices,
 		vertex_array::mode rendering_mode
 	) = 0;
 

diff --git a/src/ruis/render/vertex_array.cpp b/src/ruis/render/vertex_array.cpp
@@ -27,12 +27,11 @@ using namespace ruis::render;
 
 vertex_array::vertex_array(
 	buffers_type buffers,
-	// NOLINTNEXTLINE(modernize-pass-by-value)
-	const utki::shared_ref<const ruis::render::index_buffer>& indices,
+	utki::shared_ref<const ruis::render::index_buffer> indices,
 	mode rendering_mode
 ) :
 	buffers(std::move(buffers)),
-	indices(indices),
+	indices(std::move(indices)),
 	rendering_mode(rendering_mode)
 {
 	if (this->buffers.empty()) {

diff --git a/src/ruis/render/vertex_array.hpp b/src/ruis/render/vertex_array.hpp
@@ -58,7 +58,11 @@ class vertex_array
 	const mode rendering_mode;
 
 protected:
-	vertex_array(buffers_type buffers, const utki::shared_ref<const index_buffer>& indices, mode rendering_mode);
+	vertex_array(
+		buffers_type buffers, //
+		utki::shared_ref<const index_buffer> indices,
+		mode rendering_mode
+	);
 
 public:
 	vertex_array(const vertex_array&) = delete;

diff --git a/tests/harness/modules/ruis-render-null b/tests/harness/modules/ruis-render-null
diff --git a/tests/harness/modules/ruisapp b/tests/harness/modules/ruisapp
+105 −1		src/ruis/render/null/factory.cpp
+19 −56		src/ruis/render/null/factory.hpp
+6 −2		src/ruis/render/null/frame_buffer.cpp
+9 −1		src/ruis/render/null/frame_buffer.hpp
+7 −1		src/ruis/render/null/index_buffer.cpp
+12 −1		src/ruis/render/null/index_buffer.hpp
+7 −2		src/ruis/render/null/texture_2d.cpp
+9 −1		src/ruis/render/null/texture_2d.hpp
+15 −2		src/ruis/render/null/texture_cube.cpp
+16 −1		src/ruis/render/null/texture_cube.hpp
+2 −2		src/ruis/render/null/texture_depth.cpp
+1 −1		src/ruis/render/null/texture_depth.hpp
+6 −6		src/ruis/render/null/vertex_array.cpp
+5 −1		src/ruis/render/null/vertex_array.hpp
+18 −2		src/ruis/render/null/vertex_buffer.cpp
+16 −1		src/ruis/render/null/vertex_buffer.hpp
+1 −1		tool-configs
+1 −1		.github/workflows/ci.yml
+7 −0		.vscode/tasks.json
+2 −1		debian/control.in
+0 −1		debian/libruisapp-dev.install
+13 −8		src/makefile
+8 −1		src/ruisapp/application.hpp
+5 −2		src/ruisapp/glue/glue.cpp
+8 −4		src/ruisapp/glue/linux/glue_wayland.cxx
+4 −3		src/ruisapp/glue/linux/glue_xorg.cxx
+4 −3		src/ruisapp/glue/macosx/glue.mm
+755 −0		src/ruisapp/glue/sdl/glue.cxx
+2 −2		src/ruisapp/glue/windows/glue.cxx
+9 −1		tests/app/makefile