Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass Message Listener to Included Libraries #330

Merged
merged 6 commits into from
Jan 17, 2025

Conversation

nkarip
Copy link
Contributor

@nkarip nkarip commented Jan 16, 2025

Fix for #324

Pull requests into cql-execution require the following.
Submitter and reviewer should ✔ when done.
For items that are not-applicable, mark "N/A" and ✔.

Submitter:

  • This pull request describes why these changes were made
  • Code diff has been done and been reviewed (it does not contain: additional white space, not applicable code changes, debug statements, etc.)
  • Tests are included and test edge cases
  • Tests have been run locally and pass
  • Code coverage has not gone down and all code touched or added is covered.
  • Code passes lint and prettier (hint: use npm run test:plus to run tests, lint, and prettier)
  • All dependent libraries are appropriately updated or have a corresponding PR related to this change - N/A
  • cql4browsers.js built with npm run build:browserify if source changed.

Reviewer:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.04%. Comparing base (12a8ce0) to head (7cbb0ac).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #330   +/-   ##
=======================================
  Coverage   87.04%   87.04%           
=======================================
  Files          52       52           
  Lines        4517     4517           
  Branches     1273     1273           
=======================================
  Hits         3932     3932           
  Misses        377      377           
  Partials      208      208           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cmoesel cmoesel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. I'm surprised this mistake lasted so long in the codebase, but I guess people aren't using Message a lot in included libraries.

We run npm audit as part of our CI and it looks like it found a few issues. I don't think you introduced these, but would you mind trying to address them? Doing this on PRs ensures we keep dependencies clean before they get too out of hand. I tried it locally and it should be as simple as running npm audit fix.

I also made one other request in a specific comment on the code.

Thanks!

test/elm/message/Included.js Show resolved Hide resolved
@nkarip nkarip requested a review from cmoesel January 17, 2025 16:52
Copy link
Member

@cmoesel cmoesel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thank you, Neelima!

Copy link
Contributor

@hossenlopp hossenlopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from the fqm-execution side of things. Good tests added too.

@cmoesel cmoesel changed the title Message listener Pass Message Listener to Included Libraries Jan 17, 2025
@cmoesel cmoesel merged commit 2cd244c into cqframework:master Jan 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants