-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass Message Listener to Included Libraries #330
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #330 +/- ##
=======================================
Coverage 87.04% 87.04%
=======================================
Files 52 52
Lines 4517 4517
Branches 1273 1273
=======================================
Hits 3932 3932
Misses 377 377
Partials 208 208 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this. I'm surprised this mistake lasted so long in the codebase, but I guess people aren't using Message
a lot in included libraries.
We run npm audit
as part of our CI and it looks like it found a few issues. I don't think you introduced these, but would you mind trying to address them? Doing this on PRs ensures we keep dependencies clean before they get too out of hand. I tried it locally and it should be as simple as running npm audit fix
.
I also made one other request in a specific comment on the code.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Thank you, Neelima!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from the fqm-execution side of things. Good tests added too.
Fix for #324
Pull requests into cql-execution require the following.
Submitter and reviewer should ✔ when done.
For items that are not-applicable, mark "N/A" and ✔.
Submitter:
npm run test:plus
to run tests, lint, and prettier)cql4browsers.js
built withnpm run build:browserify
if source changed.Reviewer:
Name: