when clicking on A or BUTTON prevent dblclick

craftcms · Apr 2, 2024 · 6f8bde2 · 6f8bde2
1 parent 6cd97c6
commit 6f8bde2
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 4 deletions.
diff --git a/src/web/assets/cp/dist/cp.js b/src/web/assets/cp/dist/cp.js
diff --git a/src/web/assets/cp/dist/cp.js.map b/src/web/assets/cp/dist/cp.js.map
diff --git a/src/web/assets/cp/src/js/BaseElementIndexView.js b/src/web/assets/cp/src/js/BaseElementIndexView.js
@@ -83,7 +83,10 @@ Craft.BaseElementIndexView = Garnish.Base.extend(
       // Enable inline element editing if this is an index page
       if (this.elementIndex.isAdministrative) {
         this._handleElementEditing = (ev) => {
-          if (['A', 'BUTTON'].includes(ev.target.nodeName)) {
+          if (
+            ['A', 'BUTTON'].includes(ev.target.nodeName) ||
+            ['A', 'BUTTON'].includes(ev.target.parentNode.nodeName)
+          ) {
             // Let the link do its thing
             return;
           }

diff --git a/src/web/assets/cp/src/js/NestedElementManager.js b/src/web/assets/cp/src/js/NestedElementManager.js
@@ -382,7 +382,10 @@ Craft.NestedElementManager = Garnish.Base.extend(
     initElement($element) {
       if (Garnish.hasAttr($element, 'data-editable')) {
         this.addListener($element, 'dblclick,taphold', (ev) => {
-          if (['A', 'BUTTON'].includes(ev.target.nodeName)) {
+          if (
+            ['A', 'BUTTON'].includes(ev.target.nodeName) ||
+            ['A', 'BUTTON'].includes(ev.target.parentNode.nodeName)
+          ) {
             // Let the link/button do its thing
             return;
           }