Skip to content

Commit

Permalink
Merge pull request #14709 from craftcms/bugfix/14707-dbl-instantiatin…
Browse files Browse the repository at this point in the history
…g-checkbox-select

match the case when checking if checkboxSelect is instantiated
  • Loading branch information
brandonkelly authored Mar 27, 2024
2 parents 0220e87 + bd741de commit f07490f
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 3 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Release Notes for Craft CMS 4

## Unreleased

- Fixed a “Double-instantiating a checkbox select on an element” JavaScript warning. ([#14707](https://github.com/craftcms/cms/issues/14707))

## 4.8.6 - 2024-03-26

- Added the “Craft 5 Upgrade” utility.
Expand Down
2 changes: 1 addition & 1 deletion src/web/assets/cp/dist/cp.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/web/assets/cp/dist/cp.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/web/assets/cp/src/js/Craft.js
Original file line number Diff line number Diff line change
Expand Up @@ -2613,7 +2613,7 @@ $.extend($.fn, {
*/
checkboxselect: function () {
return this.each(function () {
if (!$.data(this, 'checkboxselect')) {
if (!$.data(this, 'checkboxSelect')) {
new Garnish.CheckboxSelect(this);
}
});
Expand Down

0 comments on commit f07490f

Please sign in to comment.