Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when clicking on A or BUTTON prevent dblclick #14743

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

i-just
Copy link
Contributor

@i-just i-just commented Apr 2, 2024

Description

We already prevent double-clicking on an a or button element.
This PR adds the same mechanism when the event target is a child of an a or button element.

Related issues

#14736

@i-just i-just requested a review from brandonkelly April 2, 2024 14:51
Consistent with 8d78ed6, and will work if the <a> or <button> is anywhere in the descendants, not just the direct parent. (And works even if ev.target is the <a>/<button>.)
[ci skip]
@brandonkelly brandonkelly merged commit 52d5fd8 into 5.x Apr 2, 2024
@brandonkelly brandonkelly deleted the bugfix/14736-click-and-dblclick branch April 2, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants