Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/14745 webauthn load the data #14747

Merged
merged 5 commits into from
Apr 3, 2024

Conversation

i-just
Copy link
Contributor

@i-just i-just commented Apr 3, 2024

Description

In Feb 2024, the web-auth/webauthn-lib was updated from ~4.7 to ~4.8. The 4.8 minor release has a breaking change, which causes the “Unable to load the data” error.

This PR

  • restricts the web-auth/webauthn-lib to ~4.8.0 so that we don’t end up in the same situation again
  • fixes the “Unable to load the data” error by using the Symphony Serializer to get the PublicKeyCredential for verifying the passkey creation response

I have verified that this allows you to log in with a passkey that was created as early as in 5.0.0-alpha.1 and that it allows you to create new passkeys.

Further changes (to stop using deprecated methods) are done on a separate feature branch as they prevent the passkeys created on earlier versions from working.

Related issues

#14745

@i-just i-just requested a review from brandonkelly April 3, 2024 10:29
@i-just i-just mentioned this pull request Apr 3, 2024
[ci skip]
@brandonkelly brandonkelly merged commit 033ba99 into 5.x Apr 3, 2024
@brandonkelly brandonkelly deleted the bugfix/14745-webauthn-load-the-data branch April 3, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants