configmap, statefulset, and readme updates #1
Conversation
krishamoud
force-pushed
the
kafka-monitoring
branch
from
31f8c51 to
99beeea
Compare
|
Note: I installed kafka on stage using these exact files so I believe they work as we would expect them to. |
nrmitchi
force-pushed
the
kafka-monitoring
branch
2 times, most recently
from
5a1850f to
c8e96f1
Compare
| failureThreshold: 3 | ||
| periodSeconds: 10 | ||
| successThreshold: 1 | ||
| tcpSocket: |
There was a problem hiding this comment.
What was the point of this change again?
There was a problem hiding this comment.
The readiness fails and the containers will never start if they use the readiness probe used by charts since jmx is using port 5000: https://github.com/kubernetes/charts/blob/master/incubator/kafka/templates/statefulset.yaml#L61
This one works: https://github.com/Yolean/kubernetes-kafka/blob/master/kafka/50kafka.yml#L63
There was a problem hiding this comment.
Ahh okay, it's good that we pulled the change from the upstream that this chart is meant to be based on. It's more defensible if we try to merge these changes into the upstream chart.
Thanks
nrmitchi
force-pushed
the
kafka-monitoring
branch
3 times, most recently
from
cacdf13 to
66d4628
Compare
|
Note that this is basically a helmification of the changes at: Yolean/kubernetes-kafka@5a2b8c7 |
nrmitchi
force-pushed
the
kafka-monitoring
branch
from
7733844 to
0a91751
Compare
Also changes the readiness probe to match the new one upstream
nrmitchi
force-pushed
the
kafka-monitoring
branch
from
0a91751 to
3ad70c0
Compare
…fka-monitoring
* Update app to latest version and qa improvements * review #1
I updated the readme, added a configmap, and updated the statefulset definition to add the prometheus sidecar.