refactor: Replace ResizeSensor with ResizeObserver #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case it is of any help with create3000#155, this PR represents starting with the current development branch, performing `npm remove css-element-queries`, deleting all occurrences of ResizeSensor and css-element-queries (they only occurred in src/x_ite.html and webpack.config.js anyway), correcting the casing of `GifMedia.js` in `src/x_ite/Components/Texturing/MovieTexture.js` (so that webpack will execute on Linux, which is case-sensitive), and then running `make dist`. The exact result of all that is committed in this PR. I don't actually know that this is a reasonable change, but I thought I would provide it for your convenience. In particular, I couldn't find any sort of developer's guide among the documentation, so I wasn't sure what all to do to try out/test a change like this. I did try "make tests" but it did not run at all (even before I made any changes to the source). Hope this helps in some way; looking forward to getting a version of x_ite that can be loaded in a browser extension.
gwhitney
changed the title
|
OK, now the only occurrence of ResizeSensor has been replaced with a ResizeObserver, which has been standard in all major browsers for some time. Now this PR should be reasonable for testing and merging, to remove the dependency on ResizeSensor.js and eliminate its side effects (such as the need to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case it is of any help with #155, this PR represents starting with
the current development branch, performing
npm remove css-element-queries,deleting all occurrences of ResizeSensor and css-element-queries (they
only occurred in src/x_ite.html and webpack.config.js anyway), correcting
the casing of
GifMedia.jsinsrc/x_ite/Components/Texturing/MovieTexture.js(so that webpack willexecute on Linux, which is case-sensitive), and then running
make dist.The exact result of all that is committed in this PR.
I don't actually know that this is a reasonable change, but I thought
I would provide it for your convenience. In particular, I couldn't find
any sort of developer's guide among the documentation, so I wasn't sure
what all to do to try out/test a change like this. I did try "make tests"
but it did not run at all (even before I made any changes to the source).
Hope this helps in some way; looking forward to getting a version of
x_ite that can be loaded in a browser extension.