Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Officially unsupport multi-line attribute blocks. #95

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AnalyzePlatypus
Copy link

Closes #74.

HAML-js does not support multiline attribute blocks.
This PR clarifies this fact in several places.

  • The error Malformed attribute block now reads Multi-line attribute blocks are unsupported in HAML-js
  • Adds a new section, Differences from Ruby HAML to the Readme, and notes that:
Multi-line attribute blocks are not supported.

HAML-js does not support multi-line attribute blocks. 
The error message now correctly notes this.
@Sinetheta
Copy link

I think that clears things up nicely. Spreading different attributes across multiple lines is handy for readability, but certainly not required. As long as users know they're not crazy, they need to adjust their markup.

@mebibou
Copy link

mebibou commented Feb 9, 2018

Having lines of 500chars because this library does not support multi-lines is not what I call readability, it's common sense. Has anyone ever wrote a function in js as a single line of 500chars? nonsense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants