Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: Made search-index.html page responsive for mobile. #246

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SumaiyaaRq
Copy link

@SumaiyaaRq SumaiyaaRq commented Oct 17, 2024

Fixes

Description

This PR resolves the responsiveness issues for smaller devices in the search-index.html page .
There are issues related to padding in posts section and overflowing of search-form in smaller devices . I have attempted to fix these issues through this PR.

Technical details

1.Made changes to the style rules defined in vocabulary.css file .
2.More specifically, layout changes have been made to the search section & posts section of the page.

Tests

  1. Open the search-index.html file.
  2. Right-click and select Inspect (or press Ctrl+Shift+I / Cmd+Option+I on Mac).
  3. Click Toggle Device Toolbar (or press Ctrl+Shift+M / Cmd+Shift+M on Mac ).
  4. Test with different devices or adjust the viewport sizes.

Screenshots

Screenshot 2024-10-17 at 8 06 07 PM

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@SumaiyaaRq SumaiyaaRq requested review from a team as code owners October 17, 2024 14:39
@SumaiyaaRq SumaiyaaRq requested review from TimidRobot, possumbilities, shailee-m and hugosolar and removed request for a team October 17, 2024 14:39
Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for vocabulary-docs ready!

Name Link
🔨 Latest commit d98eca8
🔍 Latest deploy log https://app.netlify.com/sites/vocabulary-docs/deploys/6711218afd9868000858db07
😎 Deploy Preview https://deploy-preview-246--vocabulary-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SumaiyaaRq
Copy link
Author

Hi @possumbilities ,
Just following up on this PR. Please let me know if there's anything I need to adjust or improve.
Looking forward to your feedback whenever you get a chance.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

[Bug] Mobile Responsiveness Issue on search-index.html Page
1 participant