[178] - feat: google drive integration with a sign-in flow and backup upload #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piyush Upadhyay <[email protected]>
Signed-off-by: Piyush Upadhyay <[email protected]>
Signed-off-by: Piyush Upadhyay <[email protected]>
Signed-off-by: Piyush Upadhyay <[email protected]>
…into feature/digilocker-integration
9 tasks
|
@piyushupadhyay19 Can you add the video of the feature you have completed ? |
Screenrecording_20240627_232035.mp4 |
…into feature/digilocker-integration Signed-off-by: Piyush Upadhyay <[email protected]>
sairanjit
requested changes
Jul 1, 2024
app/contexts/auth.tsx
Outdated
Comment on lines
34
to
36
| isSignedIn: boolean | ||
| signIn: () => Promise<void> | ||
| signOut: () => Promise<void> |
There was a problem hiding this comment.
Suggested change
| isSignedIn: boolean | |
| signIn: () => Promise<void> | |
| signOut: () => Promise<void> | |
| isGoogleAccountSignedIn: boolean | |
| googleSignIn: () => Promise<void> | |
| googleSignOut: () => Promise<void> |
app/contexts/auth.tsx
Outdated
Comment on lines
56
to
57
| // const userInfo = await GoogleSignin.signIn() | ||
| // await AsyncStorage.setItem('userInfo', JSON.stringify(userInfo)) |
There was a problem hiding this comment.
- If we don't need this you can remove this
app/screens/Settings.tsx
Outdated
Comment on lines
232
to
236
| Toast.show({ | ||
| type: ToastType.Success, | ||
| text1: t('GoogleDrive.SignOutGoogleSuccess'), | ||
| position: 'bottom', | ||
| }) |
There was a problem hiding this comment.
- While signing out we can remove this toast. We can just sign-out the user
app/contexts/auth.tsx
Outdated
| const [, dispatch] = useStore() | ||
| const { t } = useTranslation() | ||
|
|
||
| useEffect(() => { | ||
| const checkSignInStatus = async () => { | ||
| const userInfo = await AsyncStorage.getItem('userInfo') |
There was a problem hiding this comment.
Suggested change
| const userInfo = await AsyncStorage.getItem('userInfo') | |
| const userInfo = await AsyncStorage.getItem('googleUserInfo') |
Signed-off-by: Piyush Upadhyay <[email protected]>
piyushupadhyay19
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue ticket number and link
Checklist before requesting a review