Refacto User & Organization #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentchalamon
force-pushed
the
issues/338
branch
13 times, most recently
from
3aac121 to
d8f6123
Compare
vincentchalamon
force-pushed
the
user-system-refacto
branch
from
b1f6a90 to
7311bd3
Compare
vincentchalamon
force-pushed
the
issues/338
branch
4 times, most recently
from
443779d to
4dbef0b
Compare
vincentchalamon
force-pushed
the
issues/338
branch
from
4dbef0b to
4bd8d41
Compare
vincentchalamon
force-pushed
the
issues/338
branch
4 times, most recently
from
5e98f09 to
9251bbd
Compare
This was
linked to
issues
May 20, 2020
mRoca
reviewed
May 23, 2020
| * @ORM\ManyToMany(targetEntity="App\Entity\Organization", inversedBy="admins") | ||
| * @ORM\OrderBy({"name"="ASC"}) | ||
| */ | ||
| public Collection $organizations; |
There was a problem hiding this comment.
I'm not sure this property name is clear enough. What about $managedOrganizations or something else ? Imho $user->addOrganization() is not explicit enough
vincentchalamon
force-pushed
the
user-system-refacto
branch
from
7311bd3 to
684eafc
Compare
vincentchalamon
force-pushed
the
issues/338
branch
from
1c6b77b to
2d4e752
Compare
|
TODO check if the |
mRoca
added a commit
that referenced
this pull request
Nov 4, 2020
* Prepare Behat scenarios for User system refacto (#339) * Refacto User login * Add reset password * Add Organization promote/revoke User * Add ROLE_SUPER_ADMIN * Add User impersonification for super-admin only * Remove useless ROLE_VOLUNTEER * wip * Fix PHP-CS Co-authored-by: Michel Roca <[email protected]>
mRoca
added a commit
that referenced
this pull request
Nov 13, 2020
* Prepare Behat scenarios for User system refacto (#339) * Refacto User login * Add reset password * Add Organization promote/revoke User * Add ROLE_SUPER_ADMIN * Add User impersonification for super-admin only * Remove useless ROLE_VOLUNTEER * wip * Fix PHP-CS Co-authored-by: Michel Roca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #338 and #360 and #320 and #284