Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kubeadm 'Try Now' field #31

Merged
merged 1 commit into from
Apr 29, 2019
Merged

Conversation

haircommander
Copy link
Member

Fix an out of date link with an updated tutorial on setting up CRI-O with kubeadm

Signed-off-by: Peter Hunt [email protected]

Fix an out of date link with an updated tutorial on setting up CRI-O with kubeadm

Signed-off-by: Peter Hunt <[email protected]>
@openshift-ci-robot openshift-ci-robot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 22, 2019
@haircommander
Copy link
Member Author

haircommander commented Apr 22, 2019

fixes: #29

@haircommander
Copy link
Member Author

@rhatdan @mrunalp PTAL

@rhatdan
Copy link
Collaborator

rhatdan commented Apr 29, 2019

/approve
LGTM

Copy link
Member

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: haircommander, mrunalp, rhatdan
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:

If they are not already assigned, you can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants