Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OWNERS file #32

Merged
merged 1 commit into from
Apr 30, 2019
Merged

Add OWNERS file #32

merged 1 commit into from
Apr 30, 2019

Conversation

haircommander
Copy link
Member

To use openshift bot, we need an OWNERS file to define approvers to approve PRs

Signed-off-by: Peter Hunt [email protected]

@openshift-ci-robot openshift-ci-robot added do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Apr 29, 2019
openshift-ci-robot
openshift-ci-robot reviewed Apr 29, 2019
View reviewed changes
Copy link

@openshift-ci-robot openshift-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haircommander: 1 invalid OWNERS file

In response to this:

To use openshift bot, we need an OWNERS file to define approvers to approve PRs

Signed-off-by: Peter Hunt [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

OWNERS
@@ -0,0 +1,5 @@
approvers:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No approvers defined in this root directory OWNERS file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks typo bot

@haircommander
Copy link
Member Author

@rhatdan @mrunalp anyone we should add or remove here?

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 29, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Apr 29, 2019
@haircommander
Copy link
Member Author

@saschagrunert would you also like to be an owner here?

@saschagrunert
Copy link
Member

@saschagrunert would you also like to be an owner here?

Oh thanks for asking, sure, it would be a pleasure for me. 😇

@openshift-ci-robot openshift-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Apr 30, 2019
@haircommander
Add OWNERS file
5e6ceba 
To use openshift bot, we need an OWNERS file to define approvers to approve PRs

Signed-off-by: Peter Hunt <[email protected]>
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Apr 30, 2019
@rhatdan
Copy link
Collaborator

rhatdan commented Apr 30, 2019

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2019
@haircommander
Copy link
Member Author

@rhatdan because this PR isn't merged, you'll need to merge it manually (no owners file yet, so no approvers yet, so /approve doesn't work)

mrunalp
mrunalp approved these changes Apr 30, 2019
View reviewed changes
Copy link
Member

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: haircommander, mrunalp, rhatdan
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:

If they are not already assigned, you can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mrunalp mrunalp merged commit 749b6db into cri-o:master Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@openshift-ci-robot openshift-ci-robot openshift-ci-robot left review comments

@mrunalp mrunalp mrunalp approved these changes

Assignees

@mrunalp mrunalp

@rhatdan rhatdan

Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@haircommander @saschagrunert @rhatdan @openshift-ci-robot @mrunalp