Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CNCF project logo to main page #33

Merged
merged 1 commit into from
Apr 30, 2019
Merged

Add CNCF project logo to main page #33

merged 1 commit into from
Apr 30, 2019

Conversation

lucperkins
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 29, 2019
@TomSweeneyRedHat
Copy link
Contributor

@lucperkins can you add a screen grab of what the page would look like with these changes? Thanks!

@rhatdan
Copy link
Collaborator

rhatdan commented Apr 30, 2019

LGTM
@mrunalp PTAL

@mrunalp
Copy link
Member

mrunalp commented Apr 30, 2019

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lucperkins, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2019
@mrunalp
Copy link
Member

mrunalp commented Apr 30, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2019
@openshift-merge-robot openshift-merge-robot merged commit b9d439e into cri-o:master Apr 30, 2019
@rhatdan
Copy link
Collaborator

rhatdan commented May 1, 2019

Can we add something to the top announcing that CRI-O has been donated to the CNCF, and connet to a blog on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants