Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all Github links pointing to cri-o/cri-o #35

Merged
merged 1 commit into from
Jul 27, 2019

Conversation

odinuge
Copy link
Contributor

@odinuge odinuge commented Jul 26, 2019

Remove old kubernetes-incubator & kubernetes-sigs links.

@openshift-ci-robot openshift-ci-robot added the dco-signoff: no Indicates the PR's author has not DCO signed all their commits. label Jul 26, 2019
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 26, 2019
Remove old kubernetes-incubator & kubernetes-sigs links.

Signed-off-by: Odin Ugedal <[email protected]>
@openshift-ci-robot openshift-ci-robot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Jul 26, 2019
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: odinuge, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2019
@@ -79,7 +79,7 @@ CRI-O is made up of several components that are found in different GitHub reposi
* [containers/storage](https://github.com/containers/storage)
* [containers/image](https://github.com/containers/image)
* [networking (CNI)](https://github.com/containernetworking/cni)
* [container monitoring (conmon)](https://github.com/kubernetes-incubator/cri-o/tree/master/conmon)
* [container monitoring (conmon)](https://github.com/cri-o/cri-o/tree/master/conmon)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haircommander is this correct or has conmon moved to github.com/containers/conmon?

@@ -108,7 +108,7 @@ Various CNI plugins such as Flannel, Weave and OpenShift-SDN have been tested wi

### Monitoring

[conmon](https://github.com/kubernetes-incubator/cri-o/tree/master/conmon) is a utility within CRI-O that is used to
[conmon](https://github.com/cri-o/cri-o/tree/master/conmon) is a utility within CRI-O that is used to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto previous conmon question

@TomSweeneyRedHat
Copy link
Contributor

@odinuge TYVM for these changes. This LGTM with the possible exception of the final conmon location. @haircommander can confirm/deny.

@haircommander
Copy link
Member

@TomSweeneyRedHat for now, conmon is still built from the cri-o repo for cri-o (podman builds from containers/conmon). It's my intention to migrate cri-o to containers/conmon but that migration hasn't happened yet

@haircommander
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2019
@openshift-merge-robot openshift-merge-robot merged commit 78d7d17 into cri-o:master Jul 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants