-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix all Github links pointing to cri-o/cri-o #35
Conversation
Remove old kubernetes-incubator & kubernetes-sigs links. Signed-off-by: Odin Ugedal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: odinuge, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -79,7 +79,7 @@ CRI-O is made up of several components that are found in different GitHub reposi | |||
* [containers/storage](https://github.com/containers/storage) | |||
* [containers/image](https://github.com/containers/image) | |||
* [networking (CNI)](https://github.com/containernetworking/cni) | |||
* [container monitoring (conmon)](https://github.com/kubernetes-incubator/cri-o/tree/master/conmon) | |||
* [container monitoring (conmon)](https://github.com/cri-o/cri-o/tree/master/conmon) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@haircommander is this correct or has conmon moved to github.com/containers/conmon?
@@ -108,7 +108,7 @@ Various CNI plugins such as Flannel, Weave and OpenShift-SDN have been tested wi | |||
|
|||
### Monitoring | |||
|
|||
[conmon](https://github.com/kubernetes-incubator/cri-o/tree/master/conmon) is a utility within CRI-O that is used to | |||
[conmon](https://github.com/cri-o/cri-o/tree/master/conmon) is a utility within CRI-O that is used to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto previous conmon question
@odinuge TYVM for these changes. This LGTM with the possible exception of the final conmon location. @haircommander can confirm/deny. |
@TomSweeneyRedHat for now, conmon is still built from the cri-o repo for cri-o (podman builds from containers/conmon). It's my intention to migrate cri-o to containers/conmon but that migration hasn't happened yet |
/lgtm |
Remove old kubernetes-incubator & kubernetes-sigs links.