Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation instructions for f30 and rawhide #36

Merged
merged 1 commit into from
Oct 18, 2019

Conversation

haircommander
Copy link
Member

Signed-off-by: Peter Hunt [email protected]

@openshift-ci-robot openshift-ci-robot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Aug 12, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 12, 2019
@haircommander
Copy link
Member Author

partial fix of cri-o/cri-o#2713

index.md Outdated
@@ -17,7 +17,11 @@ Join #cri-o on IRC (freenode)

### Distribution Packaging

* **Fedora**: Available on all supported Fedora versions 28, 29 and Rawhide.
* **Fedora**: Available on all supported Fedora versions.
* Fedora 30 and Rawhide
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need a "And later" type of thing here. Otherwise when F31 comes out in a few weeks you'll have to remember to up date this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh lower maintenance burden? I like

@adelton
Copy link

adelton commented Aug 13, 2019

Running merely

sudo dnf module install cri-o

as the commit suggests fails on Fedora 30:

Cannot enable more streams from module 'cri-o' at the same time
Unable to resolve argument cri-o
Error: Problems in request:

The module needs to be versioned ... which is sort of the problem because on each OS version, the module version will be different.

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 15, 2019
@haircommander haircommander force-pushed the fix-docs-fedora branch 6 times, most recently from aceeb9b to 6f39a7f Compare October 15, 2019 16:55
@haircommander
Copy link
Member Author

The module needs to be versioned ... which is sort of the problem because on each OS version, the module version will be different.

fixed

@TomSweeneyRedHat @rhatdan @mrunalp @umohnani8 PTAL

@adelton
Copy link

adelton commented Oct 17, 2019

The dnf module install cri-o:$VERSION command fails on latest Fedora 30:

Last metadata expiration check: 0:58:13 ago on Thu 17 Oct 2019 02:35:08 PM IST.
No default profiles for module cri-o:1.14. Available profiles: default
Error: Problems in request:
missing groups or modules: cri-o:1.14

Downgrading dnf seems to make the same command pass.

@haircommander
Copy link
Member Author

haircommander commented Oct 17, 2019

my goodness, sorry for all of this @adelton . I opened an issue here cri-o/cri-o#2897

@adelton
Copy link

adelton commented Oct 18, 2019

It seems that due to https://bugzilla.redhat.com/show_bug.cgi?id=1751765, the steps on Fedora 30 need to be

VERSION=1.14
dnf module enable cri-o:$VERSION
dnf install cri-o

@TomSweeneyRedHat
Copy link
Contributor

LGTM and happy green test buttons.

@rhatdan
Copy link
Collaborator

rhatdan commented Oct 18, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants